Remove Amino encoding support #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
remove-amino-support
branch
from
6c74dcd to
34b5c42
Compare
Amino is a legacy pre-Protobuf serialization format used by early Cosmos chains, however pretty much all of them have migrated to Protobuf by this point. Supporting both Amino and Protobuf is quite difficult as it completely duplicates effort for all serialized messages, with separate `prost` and `prost_amino` dependencies (where `prost_amino` is unmaintained) and message types which duplicate each other for both formats. TMKMS made it work by transcoding Protobuf to Amino back to Protobuf (for both requests and responses). This commit fully moves TMKMS to be natively Protobuf and Protobuf alone. The test suite previously only exercised the Amino functionality and has been fully updated to use Protobufs instead.
tony-iqlusion
force-pushed
the
remove-amino-support
branch
from
34b5c42 to
9cc9eec
Compare
tony-iqlusion
changed the title
Shella
approved these changes
Oct 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amino is a legacy pre-Protobuf serialization format used by early Cosmos chains, however pretty much all of them have migrated to Protobuf by this point.
Supporting both Amino and Protobuf is quite difficult as it completely duplicates effort for all serialized messages, with separate
prostandprost_aminodependencies (whereprost_aminois unmaintained) and message types which duplicate each other for both formats. TMKMS made it work by transcoding Protobuf to Amino back to Protobuf (for both requests and responses).This commit fully moves TMKMS to be natively Protobuf and Protobuf alone.
The test suite previously only exercised the Amino functionality and has been fully updated to use Protobufs instead.