Don't run on push anymore

Test running against itself to see if the numbers will be similar
ire4ever1190 · Oct 29, 2024 · fd220df · fd220df
1 parent 710eec2
commit fd220df
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml
@@ -1,7 +1,6 @@
 name: Benchmarking
 
 on:
-  push: # Remove when finished
   pull_request:
 
 permissions:
@@ -34,7 +33,7 @@ jobs:
       run: cp .github/workflows/bench.sh bench.sh
 
     - name: Run on master
-      run: ./bench.sh master
+      run: ./bench.sh $GITHUB_SHA
 
     - name: Run on branch
       run: ./bench.sh $GITHUB_SHA

diff --git a/.github/workflows/stats.nim b/.github/workflows/stats.nim
@@ -17,8 +17,10 @@ template formatVal(x: float): string = formatFloat(x, ffDecimal, 5)
 template writeRow(metric: untyped, name: string, lowerBetter = true) =
   let
     diff = (when lowerBetter: -1 else: 1) * (candidate.metric - baseline.metric)
-    percentage = formatFloat((diff / baseline.metric) * 100, ffDecimal, 2)
-  echo "|", name, "|", formatVal(baseline.metric), "|", formatVal(candidate.metric), "|", percentage, "|"
+    percentage = (diff / baseline.metric) * 100
+    sign = (if percentage >= 0: "+" else: "")
+    formattedPercentage = sign & formatFloat(percentage, ffDecimal, 2)
+  echo "|", name, "|", formatVal(baseline.metric), "|", formatVal(candidate.metric), "|", formattedPercentage, "|"
 
 echo "| Metric | Baseline | Candidate | Difference (%) |"
 echo "|--------|----------|-----------|----------------|"