Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TKW] Kernel cache changes #351

Merged
merged 3 commits into from
Dec 20, 2024
Merged

[TKW] Kernel cache changes #351

merged 3 commits into from
Dec 20, 2024

Conversation

Hardcode84
Copy link
Contributor

@Hardcode84 Hardcode84 commented Dec 19, 2024 •
edited
Loading

  • Disable filesystem-based kernel caching by default as it too human error prone
  • Do not access cache_manager and do not compute kernel hash if caching is disabled.
  • Only run cache tests is caching is enabled

@Hardcode84
cache changes
a31e3ad 
Signed-off-by: Ivan Butygin <[email protected]>
@Hardcode84 Hardcode84 changed the title cache changes [TKW] Kernel cache changes Dec 19, 2024
@Hardcode84 Hardcode84 marked this pull request as ready for review December 19, 2024 20:11
@Hardcode84
env var
aae89f3 
Signed-off-by: Ivan Butygin <[email protected]>
@Hardcode84
change dewfault
dcf3ecc 
Signed-off-by: Ivan Butygin <[email protected]>
harsh-nod
harsh-nod approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@harsh-nod harsh-nod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Hardcode84 Hardcode84 merged commit d4ef311 into iree-org:main Dec 20, 2024
10 checks passed
@Hardcode84 Hardcode84 deleted the cache-fixes branch December 20, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh-nod harsh-nod harsh-nod approved these changes

@raikonenfnu raikonenfnu Awaiting requested review from raikonenfnu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hardcode84 @harsh-nod