Update README.md #102
Open
Update README.md #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update to Java @alex-litvak |
alex-litvak
reviewed
May 19, 2022
| Assert.assertEquals(Alert.typeProgressive, info.getAlerts().get(0).getType()); | ||
| Assert.assertEquals("some_q", info.getAlerts().get(0).getQueue()); | ||
| } | ||
|
|
There was a problem hiding this comment.
@Ayodejiola If you delete the whole method - you should delete all the headers and lines. In this case you should delete all the lines between 659 and 677
alex-litvak
reviewed
May 19, 2022
|
|
||
| /** | ||
| * Delete alerts from a queue. If there is no queue, an EmptyQueueException is thrown. | ||
| * @param alert_ids The array list of alert ids. | ||
| * @throws io.iron.ironmq.HTTPException If the IronMQ service returns a status other than 200 OK. | ||
| * @throws java.io.IOException If there is an error accessing the IronMQ server. | ||
| */ |
There was a problem hiding this comment.
lines 797 - 799 should also be deleted
alex-litvak
reviewed
May 19, 2022
| * @throws InterruptedException | ||
| */ | ||
| @Test(expected = HTTPException.class) | ||
| public void testDeleteQueue() throws IOException, InterruptedException { |
There was a problem hiding this comment.
Why do you delete this?
alex-litvak
reviewed
May 19, 2022
|
|
||
| /** | ||
| * Delete alerts from a queue. If there is no queue, an EmptyQueueException is thrown. | ||
| * @param alert_ids The array list of alert ids. | ||
|
|
||
| * @throws io.iron.ironmq.HTTPException If the IronMQ service returns a status other than 200 OK. | ||
| * @throws java.io.IOException If there is an error accessing the IronMQ server. | ||
| */ |
There was a problem hiding this comment.
lines that should be deleted
There was a problem hiding this comment.
Can't find these. Did you delete it already?
alex-litvak
reviewed
May 19, 2022
| @@ -785,59 +779,23 @@ public QueueModel update(QueueModel model) throws IOException { | |||
| } | |||
|
|
|||
| /** | |||
| * Add alerts to a queue. If there is no queue, an EmptyQueueException is thrown. | |||
| * @param alerts The array list of alerts. | |||
| * @throws io.iron.ironmq.HTTPException If the IronMQ service returns a status other than 200 OK. | |||
| * @throws java.io.IOException If there is an error accessing the IronMQ server. | |||
| */ | |||
There was a problem hiding this comment.
lines that should be deleted as well
There was a problem hiding this comment.
Can't find these. Did you delete it already?
Restored deleted lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.