chore: reduce Kubernetes client qps and burst limits to match control…

…ler-runtime defaults. see https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/client/config/config.go#L101-L106
ironcore-dev · Nov 25, 2024 · 7833274 · 7833274
1 parent 8b7d861
commit 7833274
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/broker/bucketbroker/cmd/bucketbroker/app/app.go b/broker/bucketbroker/cmd/bucketbroker/app/app.go
@@ -38,8 +38,8 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) {
 	fs.StringVar(&o.Kubeconfig, "kubeconfig", o.Kubeconfig, "Path pointing to a kubeconfig file to use.")
 	fs.StringVar(&o.Address, "address", "/var/run/iri-bucketbroker.sock", "Address to listen on.")
 
-	fs.Float32VarP(&o.QPS, "qps", "", 100, "Kubernetes client qps.")
-	fs.IntVar(&o.Burst, "burst", 200, "Kubernetes client burst.")
+	fs.Float32VarP(&o.QPS, "qps", "", 20, "Kubernetes client qps.")
+	fs.IntVar(&o.Burst, "burst", 30, "Kubernetes client burst.")
 
 	fs.StringVar(&o.Namespace, "namespace", o.Namespace, "Target Kubernetes namespace to use.")
 	fs.StringVar(&o.BucketPoolName, "bucket-pool-name", o.BucketPoolName, "Name of the target bucket pool to pin buckets to, if any.")

diff --git a/broker/machinebroker/cmd/machinebroker/app/app.go b/broker/machinebroker/cmd/machinebroker/app/app.go
@@ -53,8 +53,8 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) {
 	fs.StringToStringVar(&o.BrokerDownwardAPILabels, "broker-downward-api-label", nil, "The labels to broker via downward API. "+
 		"Example is for instance to broker \"root-machine-uid\" initially obtained via \"machinepoollet.ironcore.dev/machine-uid\".")
 
-	fs.Float32VarP(&o.QPS, "qps", "", 100, "Kubernetes client qps.")
-	fs.IntVar(&o.Burst, "burst", 200, "Kubernetes client burst.")
+	fs.Float32VarP(&o.QPS, "qps", "", 20, "Kubernetes client qps.")
+	fs.IntVar(&o.Burst, "burst", 30, "Kubernetes client burst.")
 
 	fs.StringVar(&o.Namespace, "namespace", o.Namespace, "Target Kubernetes namespace to use.")
 	fs.StringVar(&o.MachinePoolName, "machine-pool-name", o.MachinePoolName, "Name of the target machine pool to pin machines to, if any.")

diff --git a/broker/volumebroker/cmd/volumebroker/app/app.go b/broker/volumebroker/cmd/volumebroker/app/app.go
@@ -38,8 +38,8 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) {
 	fs.StringVar(&o.Kubeconfig, "kubeconfig", o.Kubeconfig, "Path pointing to a kubeconfig file to use.")
 	fs.StringVar(&o.Address, "address", "/var/run/iri-volumebroker.sock", "Address to listen on.")
 
-	fs.Float32VarP(&o.QPS, "qps", "", 100, "Kubernetes client qps.")
-	fs.IntVar(&o.Burst, "burst", 200, "Kubernetes client burst.")
+	fs.Float32VarP(&o.QPS, "qps", "", 20, "Kubernetes client qps.")
+	fs.IntVar(&o.Burst, "burst", 30, "Kubernetes client burst.")
 
 	fs.StringVar(&o.Namespace, "namespace", o.Namespace, "Target Kubernetes namespace to use.")
 	fs.StringVar(&o.VolumePoolName, "volume-pool-name", o.VolumePoolName, "Name of the target volume pool to pin volumes to, if any.")

diff --git a/poollet/bucketpoollet/cmd/bucketpoollet/app/app.go b/poollet/bucketpoollet/cmd/bucketpoollet/app/app.go
@@ -90,8 +90,8 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) {
 
 	fs.StringVar(&o.WatchFilterValue, "watch-filter", "", "Value to filter for while watching.")
 
-	fs.Float32VarP(&o.QPS, "qps", "", 100, "Kubernetes client qps.")
-	fs.IntVar(&o.Burst, "burst", 200, "Kubernetes client burst.")
+	fs.Float32VarP(&o.QPS, "qps", "", 20, "Kubernetes client qps.")
+	fs.IntVar(&o.Burst, "burst", 30, "Kubernetes client burst.")
 	fs.IntVar(&o.MaxConcurrentReconciles, "max-concurrent-reconciles", 1, "Maximum number of concurrent reconciles.")
 }
 

diff --git a/poollet/machinepoollet/cmd/machinepoollet/app/app.go b/poollet/machinepoollet/cmd/machinepoollet/app/app.go
@@ -112,8 +112,8 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) {
 
 	fs.StringVar(&o.WatchFilterValue, "watch-filter", "", "Value to filter for while watching.")
 
-	fs.Float32VarP(&o.QPS, "qps", "", 100, "Kubernetes client qps.")
-	fs.IntVar(&o.Burst, "burst", 200, "Kubernetes client burst.")
+	fs.Float32VarP(&o.QPS, "qps", "", 20, "Kubernetes client qps.")
+	fs.IntVar(&o.Burst, "burst", 30, "Kubernetes client burst.")
 	fs.IntVar(&o.MaxConcurrentReconciles, "max-concurrent-reconciles", 1, "Maximum number of concurrent reconciles.")
 }
 

diff --git a/poollet/volumepoollet/cmd/volumepoollet/app/app.go b/poollet/volumepoollet/cmd/volumepoollet/app/app.go
@@ -91,8 +91,8 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) {
 
 	fs.StringVar(&o.WatchFilterValue, "watch-filter", "", "Value to filter for while watching.")
 
-	fs.Float32VarP(&o.QPS, "qps", "", 100, "Kubernetes client qps.")
-	fs.IntVar(&o.Burst, "burst", 200, "Kubernetes client burst.")
+	fs.Float32VarP(&o.QPS, "qps", "", 20, "Kubernetes client qps.")
+	fs.IntVar(&o.Burst, "burst", 30, "Kubernetes client burst.")
 	fs.IntVar(&o.MaxConcurrentReconciles, "max-concurrent-reconciles", 1, "Maximum number of concurrent reconciles.")
 }