Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flag declaration in *-brokers #1177

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix flag declaration in *-brokers #1177

merged 1 commit into from
Dec 4, 2024

Conversation

lukasfrank
Copy link
Member

@lukasfrank lukasfrank commented Dec 4, 2024 •
edited
Loading

Proposed Changes

  • qps and burst flag was twice declared:
panic: machinebroker flag redefined: qps

@lukasfrank lukasfrank changed the title Fix double flag declaration in *-brokers Fix flag declaration in *-brokers Dec 4, 2024
@github-actions github-actions bot added size/S bug Something isn't working labels Dec 4, 2024
@lukasfrank lukasfrank requested a review from balpert89 December 4, 2024 10:42
@lukasfrank lukasfrank marked this pull request as ready for review December 4, 2024 10:52
@lukasfrank lukasfrank requested a review from a team as a code owner December 4, 2024 10:52
@afritzler afritzler merged commit 23d9ac0 into main Dec 4, 2024
11 checks passed
@afritzler afritzler deleted the fix/double-flag-declaration branch December 4, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

@balpert89 balpert89 Awaiting requested review from balpert89

Assignees
No one assigned
Labels
bug Something isn't working size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasfrank @afritzler