Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move alias prefix to network interface spec #744

Merged
merged 1 commit into from
May 25, 2023

Conversation

adracus
Copy link
Contributor

@adracus adracus commented May 15, 2023

Remove alias prefix type in favor of NetworkInterface.Spec.Prefixes. Update all tests, docs etc.
Update machinepoollet and machinebroker.

Part of #736

@adracus adracus requested a review from a team as a code owner May 15, 2023 11:58
@github-actions github-actions bot added size/XXL bug Something isn't working documentation Improvements or additions to documentation labels May 15, 2023
@adracus adracus removed the bug Something isn't working label May 15, 2023
Remove alias prefix type in favor of `NetworkInterface.Spec.Prefixes`.
Update all tests, docs etc.
Update `machinepoollet` and `machinebroker`.
@adracus adracus force-pushed the enhance/move-aliasprefix-to-nic-spec branch from c5771f9 to dc897b7 Compare May 25, 2023 09:16
@github-actions github-actions bot added the bug Something isn't working label May 25, 2023
@adracus adracus removed the bug Something isn't working label May 25, 2023
@adracus adracus merged commit 9090c14 into main May 25, 2023
@adracus adracus deleted the enhance/move-aliasprefix-to-nic-spec branch May 25, 2023 09:28
@afritzler afritzler added the enhancement New feature or request label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking documentation Improvements or additions to documentation enhancement New feature or request size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants