Added support for .nfs files

[isaacbernat]

Added support for .nfs files (the extension Netflix uses for subtitles when downloaded from their app).

[isaacbernat]

hi @CygnaThreadbare do you know if they are really the same format? Do you have a sample file (or an excerpt) I could add to the repo and use for testing purposes to make sure new changes don't break this format? Thanks!

It would be even more awesome if you could add a small entry on the readme with instructions on how to get those .nfs files. Otherwise I'll probably add a link to https://whatext.com/nfs with a small subset of that text.

[isaacbernat]

hi @CygnaThreadbare it's been 3+ years, would you mind looking into this, or should I just close the PR without merging? Thanks! Gracias!

[CygnaThreadbare]

Sorry I completely forgot about this. It was just a lazy hack to save some time as my programming knowledge is barely enough to make tiny changes like this.

When you downloaded a movie or episode from the Netflix Android app, it downloads files like a .nfv (encrypted video), one or more .nfa (audio tracks, aac), an .nfi (an index file with the preview images shown when seeking in the player I think) and .nfs (subtitles). In most cases, but not always the .nfs files are just renamed xml files so when I got tired of renaming them while doing batch conversions I added the extension to the script. I don't have netflix anymore so I can't check if they changed any of this or the exact path the files were in but I think they were downloaded in Android/data/com.netflix.mediaclient/files/download/(some hidden subdirectory I don't remember)/(internal netflix number id for the media)/

There are some cases (saw that with japanese subtitles, my guess is that they do that with other non latin script languages too) where the .nfs is actually a several megs zip file with an index file and a separate .png image for every line (and the script obviously fails with these). So merging would mean someone who has one of these would receive an error. Never really checked if these can be converted to anything since I was mostly interested in the english and spanish ones, I guess that would require OCR. I wouldn't really merge it unless you are going to add some detection to ignore the ones that could be zip files.

I should still have a few of these somewhere on my hdd if you want to check them.

[isaacbernat]

Thanks for the additional context @CygnaThreadbare 🙏.

Yes, it'd be very useful if you could provide a sample if you still have access to one, just so I can add it in the repository as a test with a real file, not just renaming an existing xml... You may add it as an attachment or link and I can take care of the rest if you don't want to meddle with more code ;D

Btw, I am already happy with your contribution, but feel free to update the readme with this additional subtitle download method :D (yeah... I know it'd be better if you were still subscribed and could add screenshots, but this is still an improvement!)