Support n-dimensional coord Qs #1251
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having null values in the coordinates array causes errors with Array.with(). It also causes persistence problems if an answer is submitted with blanks and then re-attempted. Instead, initialise every coordinate value as the empty string.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
- Coverage 36.61% 36.60% -0.02%
==========================================
Files 451 451
Lines 19779 19785 +6
Branches 6486 6506 +20
==========================================
Hits 7243 7243
- Misses 11881 12504 +623
+ Partials 655 38 -617 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend coordinate questions to support any number of dimensions by replacing the x and y properties with a list of strings (and similarly for placeholder values).
This should be merged after the corresponding content changes and alongside the API validator changes.