Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gear be/fdr 52 be docs gateway checkin #9

Merged
merged 4 commits into from
Jun 29, 2024

Conversation

macgeargear
Copy link
Contributor

Change made

  •  New features
  •  Bug fixes
  •  Breaking changes
  • Refactor

Describe what you have done

  • create API docs for /api/v1/checkin
  • POST: /api/v1/checkin
  • user_id have to be real user_id created from user service, otherwise it will not create
Screenshot 2024-06-29 at 1 24 10 PM
  • GET: /api/v1/checkin/email/:email
Screenshot 2024-06-29 at 1 23 46 PM
  • GET: /api/v1/checkin/:userId
Screenshot 2024-06-29 at 1 21 38 PM

New Features

Fix

  • fix POST /api/v1/checkin/create to POST /api/v1/checkin
  • fix ProtoDtos return nil to [] if there're no content

Others

@macgeargear macgeargear requested a review from bookpanda June 29, 2024 06:33
@macgeargear
Copy link
Contributor Author

You might see that there are many duplicate records in which user_id, email, and event are the same value, it will be fixed after @JJnvn fixes his pr in checkin services

Makefile Outdated Show resolved Hide resolved
@bookpanda bookpanda merged commit d472f90 into dev Jun 29, 2024
2 checks passed
@bookpanda bookpanda deleted the gear-be/fdr-52-be-docs-gateway-checkin branch June 29, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants