Skip to content

Commit

Permalink
this step is no logner needed since jwks can be retrived with jwks_fe…
Browse files Browse the repository at this point in the history
…tcher config (#238)

Signed-off-by: huabing zhao <[email protected]>
  • Loading branch information
zhaohuabing authored Sep 28, 2023
1 parent e36b900 commit 02b9101
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
11 changes: 1 addition & 10 deletions bookinfo-example/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ URI to be hosted on a protected endpoint.
```shell
kubectl edit cm -n istio-system
```

Change the mesh config with the config below.

```yaml
Expand All @@ -54,15 +54,6 @@ URI to be hosted on a protected endpoint.
Alternatively you can install Istio with a sample [operator.yaml](https://github.com/istio-ecosystem/authservice/blob/master/bookinfo-example/authservice/istio-operatory.yaml) we provide when using `istioctl install -f istio-operator.yaml`.

1. Fetch the identity provider public key and populate into the configmap. In our example, run
`scripts/google-jwks.sh`.

```shell
bash scripts/google-jwks.sh
```
Copy the output JWK (with escape) literally to the [templates/config.yaml](https://github.com/istio-ecosystem/authservice/blob/master/bookinfo-example/authservice/templates/config.yaml#L30)
to replace the JWK content.

1. If you are using a Google account as your Identity Provider, you need to specify
the following redirect URL for the client ID you are using. In this example,
it would be `https://localhost:8443/productpage/oauth/callback`.
Expand Down
2 changes: 1 addition & 1 deletion bookinfo-example/authservice/values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
authservice:
image: ghcr.io/istio-ecosystem/authservice/authservice:0.4.1
image: ghcr.io/istio-ecosystem/authservice/authservice:0.5.3
# How the authservice will be enabled and enforced.
# This can be at ingress (by default) or at application sidecar.
enforcingMode: ingress
Expand Down

0 comments on commit 02b9101

Please sign in to comment.