Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the OIDC Discovery end session endpoint if present #249

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

nacx
Copy link
Collaborator

@nacx nacx commented Apr 16, 2024

Currently, the end session URI present in the OIDC Discovery response was not used. This PR fixes this and uses the URI if none was configured.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@11a2002). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage        ?   90.33%           
=======================================
  Files           ?       24           
  Lines           ?     1573           
  Branches        ?        0           
=======================================
  Hits            ?     1421           
  Misses          ?      108           
  Partials        ?       44           
Files Coverage Δ
internal/authz/oidc.go 93.61% <100.00%> (ø)

Copy link
Collaborator

@sergicastro sergicastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nacx, sergicastro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 2cbc8be into istio-ecosystem:main Apr 16, 2024
12 checks passed
@nacx nacx deleted the logout-discovery branch April 16, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants