Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate token_type case-insensitively #256

Merged
merged 3 commits into from
May 13, 2024
Merged

Validate token_type case-insensitively #256

merged 3 commits into from
May 13, 2024

Conversation

jojonium
Copy link
Contributor

Fixes #255

jojonium added 2 commits May 13, 2024 08:58
@jojonium
Validate token_type case-insensitive
3077bcb 
Signed-off-by: Joseph Petitti <[email protected]>
@jojonium
Fix indentation
8c88b50 
Signed-off-by: Joseph Petitti <[email protected]>
@sergicastro
Copy link
Collaborator

Thanks @jojonium for opening the issue and the PR 🙌🏼

It looks good to me, let me open a PR to fix the check and I'll ask you to update yours.

@sergicastro
Copy link
Collaborator

PR fixing CI / check landed the main branch, please update this one to let the checks run.

@istio-testing istio-testing merged commit 0d8008e into istio-ecosystem:main May 13, 2024
13 checks passed
@nacx
Copy link
Collaborator

nacx commented May 14, 2024

Hi @jojonium! v1.0.1 is now released with your fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergicastro sergicastro sergicastro approved these changes

@nacx nacx Awaiting requested review from nacx nacx is a code owner

@ZackButcher ZackButcher Awaiting requested review from ZackButcher ZackButcher is a code owner

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible regression: case-sensitive validation of token_type
4 participants
@jojonium @sergicastro @nacx @istio-testing