Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the latest API Version in Examples #3192

Merged
merged 1 commit into from
May 20, 2024

Conversation

whitneygriffith
Copy link
Contributor

Part of #3127
Resolves istio.io/14992

Depends on tools/2921
Builds on #3188, I will rebase once its merged

@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. needs-rebase Indicates a PR needs to be rebased before being merged size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 14, 2024
@whitneygriffith whitneygriffith added the release-notes-none Indicates a PR that does not require release notes. label May 14, 2024
@whitneygriffith
Copy link
Contributor Author

whitneygriffith commented May 14, 2024

I noticed in the protos there are aliases based on the version. For example, // $aliases: [/docs/reference/config/networking/v1alpha3/destination-rule]. How is this used? Should we remove or update this?

@whitneygriffith whitneygriffith force-pushed the latest-api-version-docs branch from 1e751c0 to c2d8c90 Compare May 14, 2024 17:33
@whitneygriffith whitneygriffith force-pushed the latest-api-version-docs branch from c2d8c90 to 542e303 Compare May 20, 2024 16:40
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 20, 2024
@whitneygriffith whitneygriffith force-pushed the latest-api-version-docs branch from 542e303 to 866342b Compare May 20, 2024 16:41
@whitneygriffith whitneygriffith marked this pull request as ready for review May 20, 2024 16:42
@whitneygriffith whitneygriffith requested a review from a team as a code owner May 20, 2024 16:42
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 20, 2024
@whitneygriffith
Copy link
Contributor Author

@ericvn PTAL

@istio-testing istio-testing merged commit db01f10 into istio:master May 20, 2024
5 checks passed
@ericvn
Copy link

ericvn commented May 20, 2024

I noticed in the protos there are aliases based on the version. For example, // $aliases: [/docs/reference/config/networking/v1alpha3/destination-rule]. How is this used? Should we remove or update this?

If I understand your question, this is simply telling Hugo that there is another address that can point to this page (it's typically used when moving or renaming a page). ie, /docs/reference/config/networking/v1alpha3/destination-rule and /docs/reference/config/networking/v1beta1/destination-rulecould be resolved and point to a/docs/reference/config/networking/v1/destination-rule` page.

@whitneygriffith whitneygriffith deleted the latest-api-version-docs branch May 20, 2024 18:30
@whitneygriffith whitneygriffith added the cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch label May 20, 2024
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #3207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose v1 examples for v1 API Docs
4 participants