🐛 ♻️ trying to fix i18n with ssr #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .vitepress/components/TagChip.vue # .vitepress/theme/LhmThemeExtension.vue # .vitepress/theme/enhancements/i18n/lang/de.ts # .vitepress/theme/enhancements/i18n/lang/en.ts # .vitepress/theme/index.ts # package-lock.json
Closed
MrSebastian
requested changes
Oct 18, 2023
# Conflicts: # .vitepress/theme/LhmThemeExtension.vue
I will solve this in a new issue, as there are other branches waiting for this i18n feature. --> #32 |
Co-authored-by: Sebastian <[email protected]>
MrSebastian
approved these changes
Oct 19, 2023
klml
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All efforts trying to get vue i18n to work with vitepress and SSR/vite failed. It either worked locally or during the build, but not both ways.
So in the end I opted for this way: Building my own translator-Composable which should behave in the same way that vue i18n did.
@MrSebastian feel free to give your feedback, too cause I build this upon your MR
Reference
Issues #20