Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/93 fix cors problem for local development #201

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

devtobi
Copy link
Member

@devtobi devtobi commented Aug 16, 2024

Description

  • Added proxy configuration for Vite dev server
  • Removed local development env file due to every request sent to relative path

Reference
Issues #93

@devtobi devtobi requested a review from a team as a code owner August 16, 2024 12:00
@devtobi devtobi linked an issue Aug 16, 2024 that may be closed by this pull request
@github-actions github-actions bot added Template: Frontend Issues regarding the frontend template. Type: Bug The issue is a bug labels Aug 16, 2024
…-development

# Conflicts:
#	stack/docker-compose.yml
Copy link
Member

@simonhir simonhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devtobi
Copy link
Member Author

devtobi commented Aug 16, 2024

The gateway side of this fix will be further taken care of in it-at-m/refarch#84

@devtobi devtobi merged commit c214fa8 into main Aug 16, 2024
5 checks passed
@devtobi devtobi deleted the bug/93-fix-cors-problem-for-local-development branch August 16, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Template: Frontend Issues regarding the frontend template. Type: Bug The issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Cors Problem for Local Development
2 participants