Use ShortenedThrowableConverter in logback config

[eidottermihi]

Description

ensures JSON formatted log lines are not cut off if too long (e.g. on docker with maximum 16kb per line on STDOUT) and breaking log managment tools that rely on proper formatted JSON messages

Reference

Issues #90

[devtobi]

I tested it locally and for some reason the JSON-formatted logging is used for all tests when running via mvn test (not just the ones annotated with the JSON-Logging profile).

On top of that please make sure you apply the following to your code:

• Run formatter via spotless:apply
• Fix Linter errors from PMD and SpotBugs via pmd:check and spotbugs:check

Everything else looks fine to me. 👍

[eidottermihi]

* Fix Linter errors from PMD and SpotBugs via `pmd:check` and `spotbugs:check`

@devtobi PMD reports errors in test sources of refarch-backend, but there's a discrepancy in PMD maven plugin configuration:

in refarch-backend tests are explicitely included (<includeTests>true</includeTests>), in refarch-eai not (default of includeTests is false).

Is this an configuration mistake? If not, I will fix PMD violations in the test sources of the backend.

[simonhir]

This would also be a candidate for a refarch lib or what do you think @devtobi? See it-at-m/refarch#55
And even if not that should probably be also migrated to the refarch-gateway

[devtobi]

* Fix Linter errors from PMD and SpotBugs via `pmd:check` and `spotbugs:check`

@devtobi PMD reports errors in test sources of refarch-backend, but there's a discrepancy in PMD maven plugin configuration:

in refarch-backend tests are explicitely included (<includeTests>true</includeTests>), in refarch-eai not (default of includeTests is false).

Is this an configuration mistake? If not, I will fix PMD violations in the test sources of the backend.

This is definitely a configuration mistake. Please enable <includeTests>true</includeTests> for refarch-eai as well, there shouldn't be too much errors being reported, because we only have very few tests. :)

Thanks. :)

[eidottermihi]

I tested it locally and for some reason the JSON-formatted logging is used for all tests when running via mvn test (not just the ones annotated with the JSON-Logging profile).

That's fixed now (marked the test with @DirtiesContext), although I still think that should not have been necessary because a Spring Test context is only shared when the context is "almost the same", and here the Spring profiles are different. So somehow the logger configuration only properly resets with an explicit @DirtiesContext 🤷

On top of that please make sure you apply the following to your code:

* Run formatter via `spotless:apply`

* Fix Linter errors from PMD and SpotBugs via `pmd:check` and `spotbugs:check`

done

[devtobi]

LGTM now. :)

[hupling]

@eidottermihi hier gehen auf alle Fälle keine Tests mehr durch https://github.com/jan-niklasml/refarch-templates/actions/runs/11053332432/job/30707454878