Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty templates. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tancred
Copy link

@tancred tancred commented Jun 10, 2016

No description provided.

@tancred
Copy link
Author

tancred commented Jun 10, 2016

My rationale behind this change is that I have templates supplied by users and a mechanism for including templates in other templates. Allowing for empty templates makes template management and error handling a lot easier.

Not sure if this is the best of even correct place for handling empty templates. For example, the changed assertions in TDTemplateEngine and TDTextNode could perhaps be removed altogether? And perhaps there's a way to return an "empty string node" a lot earlier?

Comments are most welcome. And thanks for a great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant