Skip to content

Commit

Permalink
Initialize local scratch structure before first use in non-USAC contr…
Browse files Browse the repository at this point in the history
…ol paths (#89)

Significance:
--------------
- Possibility of accessing uninitialized access to structure members of a local scratch structure uncovered with fuzzer testing.
- The changes in this commit handle such cases.

Bug: ossFuzz:68464
Test: poc in bug
  • Loading branch information
ShashankPathmudi authored May 16, 2024
1 parent e6c99d9 commit 9b16033
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions decoder/ixheaacd_api.c
Original file line number Diff line number Diff line change
Expand Up @@ -3184,6 +3184,8 @@ IA_ERRORCODE ixheaacd_dec_execute(
{
WORD element_index_order1[MAX_BS_ELEMENT];
ia_aac_dec_scratch_struct aac_scratch_struct;
memset(&aac_scratch_struct, 0, sizeof(aac_scratch_struct));

ixheaacd_allocate_aac_scr(
&aac_scratch_struct, p_state_enhaacplus_dec->aac_scratch_mem_v,
time_data, channel, p_obj_exhaacplus_dec->aac_config.ui_max_channels,
Expand Down

0 comments on commit 9b16033

Please sign in to comment.