fix: install missing language pack for GraalVM #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes itzg#2487. Also sets `LC_ALL` to `en_US.UTF-8`.
itzg
reviewed
Dec 13, 2024
| @@ -64,7 +64,7 @@ WORKDIR /data | |||
| STOPSIGNAL SIGTERM | |||
|
|
|||
| # End user MUST set EULA and change RCON_PASSWORD | |||
| ENV TYPE=VANILLA VERSION=LATEST EULA="" UID=1000 GID=1000 | |||
| ENV TYPE=VANILLA VERSION=LATEST EULA="" UID=1000 GID=1000 LC_ALL=en_US.UTF-8 | |||
There was a problem hiding this comment.
Have you tested this locale setting with the Ubuntu and Alpine based image builds?
There was a problem hiding this comment.
I have not been able to test this yet for the other distros. But since the tests pass as you said, it should be fine.
|
PR tests pass, so other base distros seem to be fine with it. |
itzg
approved these changes
Dec 14, 2024
|
Included in this build https://github.com/itzg/docker-minecraft-server/actions/runs/12333206137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2487 (followup of #2487 (comment)). Also sets
LC_ALLtoen_US.UTF-8.