Skip to content

Commit

Permalink
Increase Julia compat version to 1.4
Browse files Browse the repository at this point in the history
While I would like to support older versions of Julia, currently this
will be a little bit of work that I don't want to have to do at the
current point in time.  Increasing Julia compat version to version 1.4
in the interest of `readdir`'s keyword arguments `join` and `sort`,
the former of which is used in src/Utils.jl methods for training a
Voila Jones model.  It wouldn't be hard to implement `join` manually,
but I know not what else will need fixing in older versions of Julia,
and I don't even know if people use this package, let alone use this
package with Julia version < 1.4.  Perhaps upon request I will support
Julia versions < 1.4, but for now, this compat version will do.
  • Loading branch information
jakewilliami committed Sep 19, 2022
1 parent 334e6ca commit 0c2d885
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:
fail-fast: false
matrix:
version:
- "1.3"
- "1.6"
- "1.4" # Old version: requires 1.4 for kwargs in readdir
- "1.6" # Current LTS
- "nightly" # Latest Release
os:
- ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ IntegralArrays = "0.1"
Netpbm = "1"
ProgressMeter = "1"
QuartzImageIO = "0.7"
julia = "1"
julia = "1.4"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down

2 comments on commit 0c2d885

@jakewilliami
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/68534

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.1.0 -m "<description of version>" 0c2d8852d2fce1cf1ae51e2bfa46497649a02a4f
git push origin v1.1.0

Please sign in to comment.