Make sure generated file has actual code on exception #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parched
commented
Dec 5, 2024
| @@ -621,15 +622,20 @@ private static string CreateCSharp( | |||
| return csharp; | |||
| }); | |||
| } | |||
| catch (FlatSharpCompilationException e) | |||
| { | |||
| csharp = e.CSharp; | |||
There was a problem hiding this comment.
I think this is only really useful when code generation for reading bfbs fails, so should never be hit by an end user, but is useful for flatsharp developers
There was a problem hiding this comment.
Agree. Looks like you have a nullability error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes this line work correctly