Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket_io_abstraction wraps emitted arguments in a single object. #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aquamoth
Copy link

@aquamoth aquamoth commented Jan 9, 2018

Here is my suggestion on how to streamline the emitter in E584.

This is simple enough, but it's up to coding style if you like to wrap single arguments in an object too, like I do here, or if you prefer to sometimes emit an integer and at other times emit an object.

As always you do as you like with this code.. :)

@jamesshore
Copy link
Owner

Thanks! As always I'll not be merging the pull request directly, but it may show up on camera at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants