-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Bump Qt6 from 6.7.3 to 6.8.1 (Automated PR) #3407
base: main
Are you sure you want to change the base?
Conversation
cf2dc7c
to
e54a6c6
Compare
e54a6c6
to
4209297
Compare
4fef397
to
908b7f4
Compare
908b7f4
to
7d6c516
Compare
7d6c516
to
337d5e6
Compare
42fba64
to
3f643c1
Compare
3f643c1
to
60eeada
Compare
PR has been updated for version 6.8.1 by the workflow Bump dependencies (create-prs). |
3262e16
to
e3d19a9
Compare
a2b5b6c
to
42eccc7
Compare
I'd assume that this breaks on every Qt6 build. |
Yeah, looks like the Qt6 builders can't cope now. |
3fd0815
to
de3b9f5
Compare
The iOS linker error also occurs on a local build. So it's a general incompatibility with Qt. |
Any idea why the QFFmpeg dependency exists? |
I do absolutely not understand why we need ffmpeg. |
OK, I can repeat the Windows error locally:
This appears to be caused by Oh.
I think we're currently trying to use Yup,
works. ... But, naturally, 6.7.3 isn't compatible with msvc2022, so we have to bump both.
|
OK, that seems to have got the Qt 6.8.1 install happy, at least... let's see if it works. |
Bumped |
I think we can get windows sorted out. iOS might not be that easy since we depend on Qt developers potentially. https://bugreports.qt.io/plugins/servlet/mobile#issue/QTBUG-129651 is tagged important but I have a bad feeling. https://bugreports.qt.io/plugins/servlet/mobile#issue/QTBUG-126817 I believe that qtmultimedia pulls FFmpeg as dependency. -> we need to find and add the iOS ffmpeg libraries manually |
Mmm...
Don't like the idea of moving to cmake. (And, at some point, we need to get Linux off 5.12.8 onto a newer version, too.) |
Something like this in a dependencies step? |
Probably. As far as I read, the Qt installer ships prebuilt ffmpeg binaries. We probably need to find the path where these files are. |
Agree. |
OK:
For comparison:
(There's more on the FFMpeg dependency here: https://doc.qt.io/qt-6/qtmultimedia-building-from-source.html -- not that I think it's helpful.) What is worth noting: https://doc.qt.io/qt-6/qtmultimedia-index.html#licenses-and-attributions -- if we're distributing a statically linked Qt6 multimedia, we're distributing other libraries, so we should add them to the list. AND
That might fix it, too... no idea where to put a "cmake variable"... (Maybe |
fff7671
to
6e63b13
Compare
#3451 for the Windows fix (plus this commit). |
Dunno if this is not helping....
and that doesn't happen in the iOS builder. |
I think this is fixed here: jamulus/.github/autobuild/ios.sh Line 70 in 6e63b13
|
Second try at the iOS build -- the truncated log messages don't help. EDIT: Oh, click the line number and it relists everything fully.
Well, I don't see it having passed the flag... |
I believe we need to link a pre-compiled file from plugins/multimedia. Via Xcode GUI, It's possible to add a library manually. Then - most likely - there's a qmake variable for the linker (yes, this could be CXXFLAGS) where we'd add it manually. |
Maybe also https://github.com/deepin-community/qt6-multimedia/blob/bc546c744fbab91bc9359f56001dfac464f17388/src/multimedia/Qt6MultimediaMacros.cmake#L6 helps. This defines how cmake loads ffmpeg. |
Update: Loading all *.framework files form iOS/ffmpeg/ by putting them in the root and then including them via the Xcode GUI makes the app build. However, it crashes while opening it on the device since it cannot find the framework. https://forum.qt.io/topic/104023/how-to-add-a-ios-framework-to-qt-project/7 |
I think it's worth to wait a bit since there seem to be multiple issues on iOS with the move to ffmpeg on the Qt side (https://www.reddit.com/r/QtFramework/comments/1gh5xb2/issues_with_qt_68_and_ffmpeg_on_ios_anyone_else/). I hope there'll be a fix in the next months. |
6e63b13
to
f3a6c63
Compare
f3a6c63
to
1769630
Compare
This automated Pull Request updates the used Qt6 version to version 6.8.1.
This PR was opened by the workflow Bump dependencies (create-prs)
CHANGELOG: Build: Updated bundled Qt6 to version 6.8.1