This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 89
start working on themes #479
Open
bilelmoussaoui
wants to merge
17
commits into
master
Choose a base branch
from
themes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
cd551bc
start working on themes
bilelmoussaoui 94fd767
add themes json file, read local and global themes, install themes on…
bilelmoussaoui 46a2b88
few fixes
bilelmoussaoui c648d28
remove unneeded class
bilelmoussaoui d9e9e18
always load article from file, gresource not used anymore
bilelmoussaoui de0d630
fix flatpak folder, and add a fallback theme, fix building
bilelmoussaoui 38f7a11
more fixes
bilelmoussaoui 8b633eb
few fixes, works perfectly
bilelmoussaoui f33303e
Merge branch 'master' into themes
bilelmoussaoui d8e046d
use struct for themeInfo
bilelmoussaoui 6fdb4d9
update to master
bilelmoussaoui a849460
remove UtilsUI and fix merge confilicts
bilelmoussaoui d976d49
remove old source files from CMakeLists
bilelmoussaoui 8f5aae5
restore the GrabberConfig
bilelmoussaoui 086e6b6
update Utils & catch GLib.Error on ArticleTheme
bilelmoussaoui 4100269
space2tabs
bilelmoussaoui 6bb6fac
fix themes loading, add pre/code tags theming, fix img width & height
bilelmoussaoui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <!DOCTYPE> | ||
| <html> | ||
| <head> | ||
| <title>FeedReader Article View</title> | ||
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <style> | ||
| $CSS | ||
| </style> | ||
| </head> | ||
|
|
||
| <body style="font-size:$FONTSIZEpt;font-family:$FONTFAMILY;"> | ||
|
|
||
| <div id="feedreader-container"> | ||
| <article> | ||
| <header class="unselectable"> | ||
| <div id="source" style="font-size:$SMALLSIZEpt;">$FEED</div> | ||
| <div id="title" target="_blank" style="font-size:$LARGESIZEpt;"><a href="$URL">$TITLE</a></div> | ||
| <div id="author" style="font-size:$SMALLSIZEpt;"> | ||
| $AUTHOR | ||
| </div> | ||
| </header> | ||
|
|
||
| <div id="content" class="$UNSELECTABLE"> | ||
| $HTML | ||
| </div> | ||
|
|
||
| </article> | ||
| </div> | ||
|
|
||
|
|
||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| html, body { | ||
| margin: 0; | ||
| padding: 0; | ||
| width: auto; | ||
| } | ||
| a { | ||
| text-decoration: none; | ||
| color: #000; | ||
| } | ||
|
|
||
|
|
||
| .unselectable { | ||
| -webkit-user-select: none; | ||
| -webkit-touch-callout: none; | ||
| -webkit-user-drag: none; | ||
| user-select: none; | ||
| } | ||
|
|
||
|
|
||
| a:hover { | ||
| opacity:0.7; | ||
| } | ||
|
|
||
| body{ | ||
| font-family: Arial, Helvetica, sans-serif; | ||
| } | ||
| img { | ||
| width: 100%; | ||
| } | ||
|
|
||
| p { | ||
| text-align: justify; | ||
| } | ||
|
|
||
| #feedreader-container { | ||
| background-color: #FFFFFF; | ||
| margin: 10px; | ||
| padding: 20px; | ||
| } | ||
| #feedreader-container article header { | ||
| font-family: LyonText,Georgia,serif; | ||
| margin-bottom: 50px; | ||
| } | ||
|
|
||
| #feedreader-container article header #title { | ||
| font-size: 3em; | ||
| font-weight: 400; | ||
| line-height: 1.3em; | ||
| margin-bottom: 5px; | ||
| margin-top: 0; | ||
| } | ||
|
|
||
| #feedreader-container article header #author { | ||
| font-size: 1.1em; | ||
| font-weight: 400; | ||
| line-height: 0.8em; | ||
| margin-bottom: 5px; | ||
| margin-top: 0; | ||
| color: #AFAFAF; | ||
| } | ||
|
|
||
|
|
||
| #feedreader-container article #content { | ||
| margin: 5px; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "name": "Default", | ||
| "author": "Bilal Elmoussaoui" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <!DOCTYPE> | ||
| <html> | ||
| <head> | ||
| <title>FeedReader Article View</title> | ||
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <style> | ||
| $CSS | ||
| </style> | ||
| </head> | ||
|
|
||
| <body style="font-size:$FONTSIZEpt;font-family:$FONTFAMILY;"> | ||
|
|
||
| <div id="feedreader-container"> | ||
| <article> | ||
| <header class="unselectable"> | ||
| <div id="source" style="font-size:$SMALLSIZEpt;">$FEED</div> | ||
| <div id="title" target="_blank" style="font-size:$LARGESIZEpt;"><a href="$URL">$TITLE</a></div> | ||
| <div id="author" style="font-size:$SMALLSIZEpt;"> | ||
| $AUTHOR | ||
| </div> | ||
| </header> | ||
|
|
||
| <div id="content" class="$UNSELECTABLE"> | ||
| $HTML | ||
| </div> | ||
|
|
||
| </article> | ||
| </div> | ||
|
|
||
|
|
||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| html, body { | ||
| margin: 0; | ||
| padding: 0; | ||
| width: auto; | ||
| } | ||
| a, body { | ||
| color: #ECECEC; | ||
|
|
||
| } | ||
|
|
||
| .unselectable { | ||
| -webkit-user-select: none; | ||
| -webkit-touch-callout: none; | ||
| -webkit-user-drag: none; | ||
| user-select: none; | ||
| } | ||
|
|
||
| a { | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| a:hover { | ||
| opacity:0.7; | ||
| } | ||
|
|
||
| body{ | ||
| font-family: Arial, Helvetica, sans-serif; | ||
| background-color: #2E3440; | ||
| } | ||
|
|
||
| img { | ||
| width: 100%; | ||
| } | ||
|
|
||
| p { | ||
| text-align: justify; | ||
| } | ||
|
|
||
| #feedreader-container { | ||
| margin: 10px; | ||
| padding: 20px; | ||
| } | ||
| #feedreader-container article header { | ||
| font-family: LyonText,Georgia,serif; | ||
| margin-bottom: 50px; | ||
| } | ||
|
|
||
| #feedreader-container article header #title { | ||
| font-size: 3em; | ||
| font-weight: 400; | ||
| line-height: 1.3em; | ||
| margin-bottom: 5px; | ||
| margin-top: 0; | ||
| } | ||
|
|
||
| #feedreader-container article header #author { | ||
| font-size: 1.1em; | ||
| font-weight: 400; | ||
| line-height: 0.8em; | ||
| margin-bottom: 5px; | ||
| margin-top: 0; | ||
| color: #AFAFAF; | ||
| } | ||
|
|
||
|
|
||
| #feedreader-container article #content { | ||
| margin: 5px; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "name": "Midnight", | ||
| "author": "Bilal Elmoussaoui" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be make sense to use more semantic tags like
<h2>instead of<div>?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The theme isn't ready, it's just an example of how things works 👍
Once the Vala code is ready, i will work on two/three themes that will replace the default ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool, that makes sense :)