Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Webpack support #684

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improved Webpack support #684

wants to merge 5 commits into from

Conversation

code418
Copy link

@code418 code418 commented Jun 21, 2017

Amend the AMD references so that the library plugins can be used without any webpack config changes.

@janpaepke
Copy link
Owner

Could you amend these changes in the original source files instead of the dist, pls?

@janpaepke
Copy link
Owner

janpaepke commented Oct 23, 2018

Thanks!
But I'm afraid I'll have to bother you again: Please exclude the dist files (/scrollmagic) from the pr, as they are only updated when a new version is released.

note to self: I should probably make this more clear in contributing.md

@janpaepke
Copy link
Owner

janpaepke commented Oct 27, 2018

hey, thanks.
So I noticed this breaks the tests, which can't be a good sign.
I played around a little and noticed that it works, when I add
"scrollmagic": "ScrollMagic" at line 76 in dev/tests/main.js.

Unfortunately my experience with require or webpack aren't great, but I doubt this would be the right way to go about this, since the whole point of this was to make it work without additional configurations.
Do have any Idea why the tests may fail?

To run the tests use gulp test.
For more info see here:
https://github.com/janpaepke/ScrollMagic/blob/master/CONTRIBUTING.md#development-contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants