Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support groups #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mstrhakr
Copy link

@mstrhakr mstrhakr commented Sep 5, 2022

This small addition allows for groups to be passed back as part of the profile.

This is tested and working with a combination of Meshcentral and Authelia

closes #100

@kyler-rosquist-d
Copy link

Hi @jaredhanson, do you plan to merge this anytime soon? Really hoping we can get this through; otherwise, I'll have to find another approach. (cc: @mstrhakr )

@krishnadubagunta
Copy link

krishnadubagunta commented Jan 31, 2023

:+1 this is useful for us too. @jaredhanson (CC: @mstrhakr)

@kyler-rosquist-d
Copy link

openid-client supports scopes and worked well for me. @krishnadubagunta

@jaredhanson
Copy link
Owner

As a rule, I don't merge pull requests that lack corresponding tests. I'll merge this if tests are added, otherwise it'll have to wait until I have time to write the tests.

I'd also like to see examples of how Meshcentral, Authelia, and other IDPs are encoding the group claim. Just as Passport normalizes the user profile, the group claim should be normalized to a well-defined structure as well. The group claim defined by the JWT Profile for Access Tokens (RFC 9068) would make a good option for normalization.

@mstrhakr
Copy link
Author

mstrhakr commented Feb 6, 2023

As a rule, I don't merge pull requests that lack corresponding tests. I'll merge this if tests are added, otherwise it'll have to wait until I have time to write the tests.

I'd also like to see examples of how Meshcentral, Authelia, and other IDPs are encoding the group claim. Just as Passport normalizes the user profile, the group claim should be normalized to a well-defined structure as well. The group claim defined by the JWT Profile for Access Tokens (RFC 9068) would make a good option for normalization.

I'm not a real programmer but can take a crack at these tests, assuming I can base them on the current tests. I don't have nearly the free time I used to but it can't be that hard to write the tests (famous last words haha).

I'll check out the documentation you provided for cleaning up the data, I don't actually remember how it gets pulled in so I'll need some time to figure it all out again.

Happy to get the requirements though so thanks for the response!

@GegudeBR
Copy link

GegudeBR commented Jun 3, 2024

This change made groups claims work using Entra ID's OAuth2 on Wiki.js (using passport).
It would be nice to have it implemented so we don't need to manually change the files.

@UltimatumGamer
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support for 'groups' scope
6 participants