Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncronous API #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

andrey-tsaplin
Copy link

Your library implementation does not use any asynchronous APIs. It will be cool if users will be able to use your library without any callbacks too, with no effect to performance.

@andrey-tsaplin
Copy link
Author

Also your vCard Instance does not holds any data, so creating instance of vCard is absolutely unnecessary.

@jasperla
Copy link
Owner

Hi! Sorry for completely missing your awesome work. Would it be possible to rebase your commit?

@ultimate-tester
Copy link

ultimate-tester commented Dec 11, 2017

Please don't give the method the same name as the object. It should be:

VCard.Parse();

VCard can be a class with a static method named "Parse". In fact, the logic to read from file should be removed in my opinion. The logic to read from file is the responsibility of the user and not of this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants