Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor changes to modern IO article #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danthe1st
Copy link
Contributor

@danthe1st danthe1st commented Aug 5, 2024

This PR makes minor changes to the modern IO article which has been written by @cayhorstmann in #66.

These changes include:

  • using a try-with-resources block to the InputStream#transferTo example.
  • fixing a typo in the following sentence:

    Two Files.newDirectoryStream methods yields DirectoryStream instances, which can be used in enhanced for loops. There is no advantage over using Files.list.

  • adding a last_review timestamp. I didn't change the last_update because I didn't make significant content changes.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 5, 2024
Copy link
Collaborator

@ammbra ammbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you, Dan.

@danthe1st
Copy link
Contributor Author

danthe1st commented Sep 26, 2024

(fixed merge conflicts - diff before and after should be the same)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants