Skip to content

Commit

Permalink
Merge pull request #325 from javierbrea/release
Browse files Browse the repository at this point in the history
Release 4.1.0
  • Loading branch information
javierbrea authored Jan 13, 2024
2 parents 1fe6f83 + 3f7a221 commit a6b0b85
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 7 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
### Removed
### BREAKING CHANGES

## [4.1.0] - 2024-01-13

### Changed
- feat(#323): Specify which element type has issues during settings validation (Thanks to [@hmnzr](https://github.com/hmnzr))

## [4.0.1] - 2023-12-01

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-plugin-boundaries",
"version": "4.0.1",
"version": "4.1.0",
"description": "Eslint plugin checking architecture boundaries between elements",
"keywords": [
"eslint",
Expand Down
2 changes: 1 addition & 1 deletion sonar-project.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
sonar.organization=javierbrea
sonar.projectKey=javierbrea_eslint-plugin-boundaries
sonar.projectVersion=4.0.1
sonar.projectVersion=4.1.0

sonar.javascript.file.suffixes=.js
sonar.sourceEncoding=UTF-8
Expand Down
10 changes: 7 additions & 3 deletions src/helpers/validations.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,16 +140,20 @@ function validateElements(elements) {
}
if (element.mode && !VALID_MODES.includes(element.mode)) {
warnOnce(
`Invalid mode property in '${ELEMENTS}' setting. Should be one of ${VALID_MODES.join(
`Invalid mode property of type ${
element.type
} in '${ELEMENTS}' setting. Should be one of ${VALID_MODES.join(
",",
)}. Default value "${VALID_MODES[0]}" will be used instead`,
);
}
if (!element.pattern || !(isString(element.pattern) || isArray(element.pattern))) {
warnOnce(`Please provide a valid pattern in '${ELEMENTS}' setting`);
warnOnce(
`Please provide a valid pattern to type ${element.type} in '${ELEMENTS}' setting`,
);
}
if (element.capture && !isArray(element.capture)) {
warnOnce(`Invalid capture property in '${ELEMENTS}' setting`);
warnOnce(`Invalid capture property of type ${element.type} in '${ELEMENTS}' setting`);
}
});
}
Expand Down

0 comments on commit a6b0b85

Please sign in to comment.