Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Correct templating with ${from} for entry-point rule, issue #340 #343

Merged
merged 3 commits into from
Nov 11, 2024
Merged

FIX: Correct templating with ${from} for entry-point rule, issue #340 #343

merged 3 commits into from
Nov 11, 2024

Conversation

DeyLak
Copy link
Contributor

@DeyLak DeyLak commented Nov 8, 2024

Closing issues
closes #340

@DeyLak DeyLak mentioned this pull request Nov 8, 2024
Closed
@javierbrea javierbrea changed the base branch from master to release November 8, 2024 09:14
@javierbrea javierbrea self-requested a review November 8, 2024 09:15
@coveralls
Copy link

coveralls commented Nov 8, 2024 •
edited
Loading

Coverage Status

coverage: 99.388% (+0.002%) from 99.386%
when pulling 019c6e8 on DeyLak:fix/340-entry-point-from-templating
into e0ac567 on javierbrea:release.

@DeyLak
Copy link
Contributor Author

DeyLak commented Nov 8, 2024 •
edited
Loading

This fix didn't break any existing tests, so I consider previous behaviour a bug and only updating patch version number

@javierbrea javierbrea merged commit cb02668 into javierbrea:release Nov 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierbrea javierbrea Awaiting requested review from javierbrea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[entry-point] target option has captured values from the target dependency when templating ${from}.PROP
3 participants
@DeyLak @coveralls @javierbrea