Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confidence bounds for regression tests #540

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Conversation

jnsbck
Copy link
Contributor

@jnsbck jnsbck commented Dec 3, 2024

Regression is now evaluated with a single sample t-test, i.e. the baseline times = conf bounds. This is much nicer imo and giving a confidence region for tests to pass should also make it more robust to potential runtime fluctuations on the github runners.

Also made a few smaller follow up fixes for #475.

@jnsbck
Copy link
Contributor Author

jnsbck commented Dec 3, 2024

/update_regression_baselines

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Regression Baseline Update

✅ Process completed

test_runtime(num_cells=1, artificial=False, connect=False, connection_prob=0.0, voltage_solver=jaxley.stone)
🔴 build_time: (+245.14% vs 0.547s).
🔴 compile_time: (+7.76% vs 18.720s).
🔴 run_time: (+1.69% vs 2.817s).

test_runtime(num_cells=1, artificial=False, connect=False, connection_prob=0.0, voltage_solver=jax.sparse)
🔴 build_time: (+13.18% vs 0.317s).
🔴 compile_time: (+16.14% vs 3.107s).
🔴 run_time: (+22.99% vs 2.442s).

test_runtime(num_cells=10, artificial=False, connect=True, connection_prob=0.1, voltage_solver=jaxley.stone)
🔴 build_time: (+151.64% vs 1.628s).
🔴 compile_time: (+3.82% vs 29.477s).
🟠 run_time: (-0.61% vs 19.020s).

test_runtime(num_cells=10, artificial=False, connect=True, connection_prob=0.1, voltage_solver=jax.sparse)
🔴 build_time: (+52.30% vs 1.253s).
🔴 compile_time: (+3.75% vs 26.463s).
🔴 run_time: (+0.29% vs 25.086s).

test_runtime(num_cells=1000, artificial=True, connect=True, connection_prob=0.001, voltage_solver=jaxley.stone)
🟠 build_time: (-1.99% vs 110.895s).
🔴 compile_time: (+5.56% vs 45.626s).
🔴 run_time: (+0.74% vs 41.248s).

test_runtime(num_cells=1000, artificial=True, connect=True, connection_prob=0.001, voltage_solver=jax.sparse)
🔴 build_time: (+1.15% vs 108.675s).
🔴 compile_time: (+9.06% vs 60.998s).
🔴 run_time: (+4.69% vs 59.059s).

✨ Changes have been pushed directly to this PR

@jnsbck jnsbck mentioned this pull request Dec 3, 2024
@jnsbck jnsbck merged commit dddd1b7 into main Dec 3, 2024
1 of 2 checks passed
@jnsbck jnsbck deleted the add_baseline_hypothesis_testing branch December 3, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants