Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started: Kind of Series (HeroSeries) #135

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

henrifroese
Copy link
Collaborator

@henrifroese henrifroese commented Aug 4, 2020

Only a first draft at the moment; critique welcome (you can have a look at it e.g. by pasting everything in here .

Focus on / extended explanation of Representation Series

Question: Is this the correct location for the file (website/docs/)?

Focus on Representation Series

Co-authored-by: Maximilian Krahn <[email protected]>
@henrifroese henrifroese added the documentation Improvements or additions to documentation label Aug 4, 2020
@jbesomi jbesomi changed the title Tutorial on the different Series Types Getting started: Kind of Series Aug 5, 2020
@jbesomi jbesomi changed the title Getting started: Kind of Series Getting started: Kind of Series (HeroSeries) Aug 5, 2020
@jbesomi
Copy link
Owner

jbesomi commented Aug 5, 2020

Only a first draft at the moment; critique welcome (you can have a look at it e.g. by pasting everything in here.

You can directly add it to the website so that we can see it by clicking "view deployment".

Also, "view file" do the job: view file.

Question: Is this the correct location for the file (website/docs/)?

See #94 for a better contextualization. The idea is to have this file under the "Getting Started" tab.

We might want to call this file: getting-started-heroseries.md

Review:

  1. Very good start 💪
  2. The style should be aligned somehow with the getting-started document. I would start a bit gently by showing some examples and explain a bit deeper.
  3. Before actually writing the content, we can just discuss the structure, the different headings, and sub-headings and the content of each sub-heading, without writing it?

Structure (just a draft)

#HeroSeries

One line intro to give an idea on the subject

Overview

Explain the why
Show the 4

TextSeries

...

TokenSeries

...

RepresentationSeries

...

VectorSeries

  • mention better to avoid, used for pca as practical

Open question:

We can have either this page just after the "Getting Started" page or at the end.

Version 1:

  1. Getting Started
  2. Preprocessing
  3. Representation
  4. NLP
  5. Visualization
  6. HeroSeries

Version 2:

  1. Getting Started
  2. HeroSeries
  3. Preprocessing
  4. Representation
  5. NLP
  6. Visualization

We should consider which solution works best, particularly taking into consideration the content of the other pages.

The advantage of Version 1 is that the user understand immediately what HeroSeries are and stand for.

Advantage of Version 2 is that the user got to see the whole pipeline in the details and he should be more aware of the difference between the Series. On the other hand, it's also true that the "1. Getting Started" already provides a general introduction to the pipeline.

Long story short, we need to have clear in mind the aim of this documentation page as well as how it will interface with the rest of the documentation. The idea again here is to provide a simple and unified view of Texthero.

I believe we can aim toward a results similar to the docusaurus documentation: doc.

Extra:

  • We need to explain clearly that these are just Pandas Series, nothing else

- rename to getting-started-heroseries
- adapt suggested structure
- improve content
@henrifroese
Copy link
Collaborator Author

Advantage of Version 2 is that the user got to see the whole pipeline in the details and he should be more aware of the difference between the Series. On the other hand, it's also true that the "1. Getting Started" already provides a general introduction to the pipeline.

We agree with this. Getting started provides an overview, then we have a deep-dive for the users really interested in the different modules through Preprocessing, Representation, NLP, Visualization; and if they still want to know more, they get to the HeroSeries stuff. I think many users will read the getting started, and then later on when googling they will land on texthero.org and then see the TextSeries, RepresentationSeries, ... in the docstrings. This will lead them to the tutorial too as we'll link it in the docstrings!

Also, we just improved the content / explained in more detail, and changed to your proposed structure.

This was referenced Aug 8, 2020
@mk2510 mk2510 marked this pull request as ready for review September 5, 2020 16:57
@jbesomi jbesomi marked this pull request as draft September 14, 2020 15:45
website/docs/getting-started-herotypes.md Outdated Show resolved Hide resolved
website/docs/getting-started-herotypes.md Outdated Show resolved Hide resolved
website/docs/getting-started-herotypes.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants