Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drop duplicates; closes #4 #150

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add drop duplicates; closes #4 #150

wants to merge 3 commits into from

Conversation

mk2510
Copy link
Collaborator

@mk2510 mk2510 commented Aug 11, 2020

closes #4

added the drop duplicates function to the representation module 🤖 and created unit test :octocat:

mk2510 and others added 3 commits August 10, 2020 22:04
@mk2510 @henrifroese
drop duplicates implemented
0b8a828 
missing: test and comments



Co-authored-by: Henri Froese <[email protected]>
@mk2510
added comments
a47bef5 
missing: tests
@mk2510
added unit tests
2af6888
@mk2510 mk2510 marked this pull request as draft August 12, 2020 15:36
@henrifroese
Copy link
Collaborator

Put on hold until Series Types are figured out.

@henrifroese henrifroese changed the title Added function drop duplicates Add drop duplicates; closes #4 Aug 13, 2020
@henrifroese
Copy link
Collaborator

  • Prepare tutorial for different options (pairwise distances, clustering, hashing, approximation algo) to drop duplicates and maybe not implement it in texthero

@henrifroese henrifroese added the enhancement New feature or request label Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add drop_duplicates
2 participants
@mk2510 @henrifroese