-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HeroTypes in Representation; DataFrame in _types #157
HeroTypes in Representation; DataFrame in _types #157
Conversation
suport MultiIndex as function parameter returns MultiIndex, where Representation was returned * missing: correct test Co-authored-by: Henri Froese <[email protected]>
*missing: test adopting for new types Co-authored-by: Henri Froese <[email protected]>
- add functionality for decorator @InputSeries to handle several allowed input types - Add typing decorator/hints to representation.py - add tests for _types DocumentTermDF Co-authored-by: Maximilian Krahn <[email protected]>
…lumn' into Hero_Types_in_Representation
we have now also adopted the type checks. The given DataFrame should not be a multicolumn one, but a "normal" Sparse DataFrame. We decided to not call it SparseDataFrame, as in the future the DataFrame may not have to be sparse. |
Nice! Just realizing that this PR solve some of the issues of #180 I will review the code details once #156 is merged. Overall questions: why do we need the |
We changed it to only DataFrame, as it also could represent a different constellation than DocumentTermDF. But when we remove this type from our pandas types, we have an Incomplete TypeCheck. For now the DataFrame typcheck is not as much worth as the Series Types, but it completes the typing of every input. |
We could of course just use the actual
|
Co-authored-by: Maximilian Krahn <[email protected]>
…to Hero_Types_in_Representation
Co-authored-by: Maximilian Krahn <[email protected]>
We have now re-merged #156 in this and solved the last remaining issues we saw. Ready to review/merge now from our side 🥉 |
Co-authored-by: Maximilian Krahn <[email protected]>
From our side, this is now ready to be re-reviewed / merged 🤞 🍼 |
Thanks! Merged 🎉 🎉 That's a big milestone! |
Great! 🎉🎉🎉. We will now go through all PRs in the merge checklist that are branched from this and change them accordingly! 💡👍 |
DocumentTermDF
in forRepresentationSeries
in_types.py
@InputSeries
to handle several allowed input typesrepresentation.py
test_types.py
NOTE: only so many commits/lines as this builds on #156