Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUSETOOLS-3655 - Provide property for additional exports for JDK 17 #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apupier
Copy link
Member

@apupier apupier commented Jul 26, 2022

it avoids this kind of error java.lang.IllegalAccessException: class
org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access
class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat)
because module jdk.internal.jvmstat does not export sun.jvmstat.monitor
to unnamed module

it is provided in p2.inf but need to add it in test explicitely too. See
https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf

Signed-off-by: Aurélien Pupier [email protected]

it avoids this kind of error java.lang.IllegalAccessException: class
org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access
class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat)
because module jdk.internal.jvmstat does not export sun.jvmstat.monitor
to unnamed module

it is provided in p2.inf but need to add it in test explicitely too. See
https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf

Signed-off-by: Aurélien Pupier <[email protected]>
apupier added a commit to apupier/jbosstools-fuse that referenced this pull request Jul 26, 2022
it avoids this kind of error java.lang.IllegalAccessException: class
org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access
class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat)
because module jdk.internal.jvmstat does not export sun.jvmstat.monitor
to unnamed module

it is provided in p2.inf but need to add it in test explicitely too. See
https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf

This will need to be updated to reuse property coming from Jboss Tools
parent when available
jbosstools/jbosstools-build#332

Signed-off-by: Aurélien Pupier <[email protected]>
apupier added a commit to apupier/jbosstools-fuse that referenced this pull request Jul 27, 2022
it avoids this kind of error java.lang.IllegalAccessException: class
org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access
class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat)
because module jdk.internal.jvmstat does not export sun.jvmstat.monitor
to unnamed module

it is provided in p2.inf but need to add it in test explicitely too. See
https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf

This will need to be updated to reuse property coming from Jboss Tools
parent when available
jbosstools/jbosstools-build#332

Signed-off-by: Aurélien Pupier <[email protected]>
apupier added a commit to apupier/jbosstools-fuse that referenced this pull request Jul 27, 2022
it avoids this kind of error java.lang.IllegalAccessException: class
org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access
class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat)
because module jdk.internal.jvmstat does not export sun.jvmstat.monitor
to unnamed module

it is provided in p2.inf but need to add it in test explicitely too. See
https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf

This will need to be updated to reuse property coming from Jboss Tools
parent when available
jbosstools/jbosstools-build#332

Signed-off-by: Aurélien Pupier <[email protected]>
apupier added a commit to apupier/jbosstools-fuse that referenced this pull request Jul 27, 2022
it avoids this kind of error java.lang.IllegalAccessException: class
org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access
class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat)
because module jdk.internal.jvmstat does not export sun.jvmstat.monitor
to unnamed module

it is provided in p2.inf but need to add it in test explicitely too. See
https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf

This will need to be updated to reuse property coming from Jboss Tools
parent when available
jbosstools/jbosstools-build#332

Signed-off-by: Aurélien Pupier <[email protected]>
apupier added a commit to apupier/jbosstools-fuse that referenced this pull request Jul 27, 2022
it avoids this kind of error java.lang.IllegalAccessException: class
org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access
class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat)
because module jdk.internal.jvmstat does not export sun.jvmstat.monitor
to unnamed module

it is provided in p2.inf but need to add it in test explicitely too. See
https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf

This will need to be updated to reuse property coming from Jboss Tools
parent when available
jbosstools/jbosstools-build#332

Signed-off-by: Aurélien Pupier <[email protected]>
apupier added a commit to jbosstools/jbosstools-fuse that referenced this pull request Jul 27, 2022
it avoids this kind of error java.lang.IllegalAccessException: class
org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access
class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat)
because module jdk.internal.jvmstat does not export sun.jvmstat.monitor
to unnamed module

it is provided in p2.inf but need to add it in test explicitely too. See
https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf

This will need to be updated to reuse property coming from Jboss Tools
parent when available
jbosstools/jbosstools-build#332

Signed-off-by: Aurélien Pupier <[email protected]>
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling is that it is error prone as repos that did not adapt may swallow error.
Would be better to have it in a separate profile that is activated by a property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants