Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-29058: fix build after TP update #236

Merged
merged 7 commits into from
Oct 10, 2023
Merged

JBIDE-29058: fix build after TP update #236

merged 7 commits into from
Oct 10, 2023

Conversation

sbouchet
Copy link
Collaborator

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@angelozerr
Copy link
Contributor

I have not tested but code looks good to me.

@sbouchet sbouchet mentioned this pull request Oct 10, 2023
Merged
@sbouchet sbouchet merged commit da40850 into jbosstools:main Oct 10, 2023
2 of 3 checks passed
@sbouchet sbouchet deleted the JBIDE-29058 branch October 10, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelozerr angelozerr angelozerr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbouchet @angelozerr