Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libtool and Autotools additions #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aldemira
Copy link

@aldemira aldemira commented Oct 9, 2015

Hi Jude,
I've boldly changed the source code tree and added autotool files for a standard configure - make - make install style installation, which most people are accustomed with. I've also added standard debian dir so that we can use this code in devuan & debian with not much effort. I'd like to do the same operation to vdev (and other related modules).
I'm also planning to create an rpm spec so we can infect other distors too ;)

Regards

@jcnelson
Copy link
Owner

Hi @aldemira,

Thank you so much for your pull request! I've been thinking about this in the back of my mind for a couple of days. I'm more than happy to merge scripts to make packaging easier--this is definitely something I could use help on.

However, I'm really hesitant to add support for autotools. This is a small low-level package that isn't meant to support more than a handful of modern UNIX-like operating systems (currently only Linux), and I think autotools is overkill in this particular case. The patch is almost two orders of magnitude bigger than the existing codebase--that's a lot of code to maintain, especially considering that autotools' main use-case (providing a portable build environment) doesn't really apply here.

If the reason for adding autotools is to provide a familiar ./configure; make; make install workflow, maybe there's a way to write a tiny configure script that just sets a few parameters in the Makefile (like BINDIR, INCLUDEDIR, etc.) but leaves out the rest of autotools. What do you think?

Thanks,
Jude

@aldemira
Copy link
Author

Hi Jude,
I understand that, this is quite a drastic change and an overkill for this package. Please deny the request.
However autotools make it very easy to create the configure script, I'd never dream of writing one from scratch :) Maintenance would be a nightmare (especially if someone adds support for other OS)
So I have a few questions, will you be ok if I send a new pull request for an rpm spec file and the debian/ directory for package generation using the original file tree?
And for vdev, shall I work on deb and rpm generation + autotools?

Regards,

Aldemir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants