Merge pull request #68 from jdeboer/dev

CRAN feedback

DESCRIPTION

@@ -1,16 +1,16 @@
 Package: ganalytics
-Title: Interact with Google Analytics using R
+Title: Interact with 'Google Analytics'
 Version: 0.10.4
 Date: 2018-06-23
 Authors@R: person(
     given = "Johann",
     family = "de Boer",
     role = c("aut", "cre"),
     email = "[email protected]")
-Description: Functions for querying the Google Analytics core reporting,
-    real-time, multi-channel funnel and management APIs, as well as the Google
-    Tag Manager API. Write methods are also provided for the management and
-    Google Tag Manager APIs so that you can change tag, property or view
+Description: Functions for querying the 'Google Analytics' core reporting,
+    real-time, multi-channel funnel and management APIs, as well as the 'Google
+    Tag Manager' (GTM) API. Write methods are also provided for the management and
+    GTM APIs so that you can change tag, property or view
     settings, for example. Define reporting queries using natural R expressions
     instead of being concerned as much about API technical intricacies like
     query syntax, character code escaping, and API limitations.

NEWS.md

@@ -1,8 +1,8 @@
-2018-06-23 Version type dimensions, e.g. ga:appVersion, are now coerced to `numeric_version` class, so that version numbers (e.g. ‘2.4.7’, ‘2.5.13’, ‘2.32.1’, etc...) can be correctly sorted and compared as if they were numeric values. Updated gademo.R. The dateRange class now inherits lubridate interval as its superclass. It is now possible to query more than 10 metrics with just one query.
+2018-06-23 Version type dimensions, e.g. ga:appVersion, are now coerced to `numeric_version` class, so that version numbers (e.g. ‘2.4.7’, ‘2.5.13’, ‘2.32.1’, etc...) can be correctly sorted and compared as if they were numeric values. Updated gademo.R. The dateRange class now inherits 'lubridate' interval as its superclass. It is now possible to query more than 10 metrics with just one query.
 
-2018-05-30 Additional methods to coerce ganalytics segment classes and table filters for use with the googleAnalyticsR package. Dynamic Segments objects now have a name property. Updated `googleAnalyticsR-demo` and examples in the readme file.
+2018-05-30 Additional methods to coerce ganalytics segment classes and table filters for use with the 'googleAnalyticsR' package. Dynamic Segments objects now have a name property. Updated `googleAnalyticsR-demo` and examples in the readme file.
 
-2018-02-18 Added methods for coercing a range of ganalytics classes into googleAnalyticsR classes, so that ganalytics segments, filters and expressions can be used by the google_analytics function of the googleAnalyticsR package.
+2018-02-18 Added methods for coercing a range of ganalytics classes into 'googleAnalyticsR' classes, so that ganalytics segments, filters and expressions can be used by the google_analytics function of the 'googleAnalyticsR' package.
 
 2018-02-12 Scope and negation of segment conditions can now be defined at the filter level. Fixed bug where backslashes were being escaped incorrectly in expression operands. The methods of the Segment generic function are now split into two generic functions, Segment and Segments. Segments is used to set or get a named list segments, whereas Segment is for defining a single segment to be added to a Segments list.
 
@@ -38,7 +38,7 @@ Added IsNegated generic function and method for testing whether a segment filter
 
 2015-08-17 Update to latest dimension and metrics metadata and added support for custom dimensions and device category as view filter fields. Changed default metric for real-time queries to rt:pageviews.
 2015-08-14 Added demos. Added support for new alphanumeric segment IDs. Foundations to support multiple segments within a single query.
-2015-06-05 Support the use of a lubridate interval object as a dateRange object for GA Reporting API queries.
+2015-06-05 Support the use of a 'lubridate' interval object as a dateRange object for GA Reporting API queries.
 
 2015-05-04 Added support for real-time and multi-channel-funnels reporting APIs - both formulating queries and processing the query responses.
 

R/Expr-generics.R

@@ -24,11 +24,10 @@ setGeneric(
 #' Create a Core Reporting API expression.
 #'
 #' @examples
-#' \dontrun{
+#' \donttest{
 #'   myQuery <- GaQuery(view = 123456789)
 #'   source_matches_google <- GaExpr("source", "~", "google")
 #'   TableFilter(myQuery) <- source_matches_google
-#'   GetGaData(myQuery)
 #' }
 #' @inheritParams Expr
 #'
@@ -47,11 +46,10 @@ setGeneric(
 #' Create a Multi-Channel Funnel Reporting API expression.
 #'
 #' @examples
-#' \dontrun{
+#' \donttest{
 #'   myQuery <- McfQuery(view = 123456789)
 #'   source_matches_google <- McfExpr("mcf:source", "~", "google")
 #'   TableFilter(myQuery) <- source_matches_google
-#'   GetData(myQuery)
 #' }
 #'
 #' @inheritParams Expr
@@ -71,11 +69,10 @@ setGeneric(
 #' Create a Real-Time Reporting API expression.
 #'
 #' @examples
-#' \dontrun{
+#' \donttest{
 #'   myQuery <- RtQuery(view = 123456789)
 #'   source_matches_google <- RtExpr("rt:source", "~", "google")
 #'   TableFilter(myQuery) <- source_matches_google
-#'   GetData(myQuery)
 #' }
 #'
 #' @inheritParams Expr

R/ganalytics-package.R

@@ -4,7 +4,7 @@
 #'
 #' Classes and methods for interactive use of the Google Analytics core
 #' reporting, real-time reporting, multi-channel funnel reporting, metadata,
-#' configuration management and Google Tag Manager APIs using R.
+#' configuration management and Google Tag Manager APIs.
 #'
 #' To use this package with these APIs, it is necessary to provide OAuth
 #' credentials for a Google APIs project with the necessary APIs enabled.

R/sequence.R

@@ -4,7 +4,7 @@ NULL
 
 #' sequential_segment.
 #'
-#' Create a sequence using R non-standard evaluation syntax.
+#' Create a sequence non-standard evaluation syntax.
 #'
 #' Steps must be separated by commas (\code{,}). \code{...} denotes zero or more
 #' interactions may precede the step that follows, otherwise without \code{...} then

README.md

@@ -12,7 +12,7 @@ This package provides functions for querying the Google Analytics core reporting
 
 Updates
 -------
-Support for GoogleAnalyticsR integration is now available for segments and table filter objects. You can supply these objects to the `google_analytics` function in GoogleAnalyticsR by using `as()`, supplying the appropriate GoogleAnalyticsR class names, which are `"segment_ga4"` for segments and `".filter_clauses_ga4"` for table filters. Soon GoogleanalyticsR will implictly coerce ganalytics segments and table filters so that you do not need to explictly coerce using `as()`.
+Support for GoogleAnalyticsR integration is now available for segments and table filter objects. You can supply these objects to the `google_analytics` function in GoogleAnalyticsR by using `as()`, supplying the appropriate 'GoogleAnalyticsR' class names, which are `"segment_ga4"` for segments and `".filter_clauses_ga4"` for table filters. Soon GoogleanalyticsR will implictly coerce ganalytics segments and table filters so that you do not need to explictly coerce using `as()`.
 
 Many new functions have been provided for writing segmentation expressions:
 

cran-comments.md

@@ -19,3 +19,10 @@ This is a resubmission. In this version I have:
 * Updated README.md with corrected URLs and a few other updates to the user instructions.
 
 * Reduced LICENCE to keep only the first two lines of the file.
+
+* Omitted the redundant "using R" in the package title.
+
+* Placed single quotes around package and software names in Title and Description.
+
+* Replaced \dontrun{} by \donttest{} in the Rd-files.
+

vignettes/README.html

@@ -288,8 +288,7 @@ <h4 class="date"><em>2018-06-07</em></h4>
 <div id="ganalytics" class="section level1">
 <h1>ganalytics</h1>
 <p><a href="https://travis-ci.org/jdeboer/ganalytics"><img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAFoAAAAUCAYAAAAN+ioeAAAABHNCSVQICAgIfAhkiAAAAAlwSFlzAAALEwAACxMBAJqcGAAABQBJREFUWIXdmH1ME2cAxp/76FF6DBhYIESgbHNJFRlMqIAIcWMjbhNs1pj0Dwgmi+jm4j70Dz/mHKvZnBl1cYBLE9YYCJNNggs6s/hFNGBjthCJHyPqFkFCVAKDtZSud+/+YDto7cdJmVSf5E3vvd/d0+d9cndpjzIYDJEcx5kVCoURQDTCQH++c36+I8yNXDQhg/wV+8h4IctxnJll2WpCyHzHkhROWUKSQqCQNpahIlEXWIZhjOG2sHDLE6qoJMcSlhASFo+LmXrSiiacm2LDcVHhmClU0YQQ+BtNTU1+mdwRyGMu/B+XEbBoALMybW5uluUxW///e3QU3J5zz6CPjmDcl4qLi5GcnCzLwxebzXfOpXL3L4A6XzmnnkGvaKPRCKvVCpPJBLVaLbGWlhaPY2fOOzs7fV61arUaJpMJVqsVRqPRgwUaJwoHsF6zHW35fTjwQgcSI1Ie4McL+9GY04Xs2CJpf0H8ajS8eBrHCm7BmnsRpYlGWezStvse3saULfg+7xoO515CztOrJJYUkYqvso6jLb8P6zXbcaJwwO8aghZtt9uh1+ths9lQUVHh97afOfe3XVlZie7ubuj1ejidTtlFA4BjZBKldYvR3XcOGzR7PPiyffHQfZGAPR2bUa2pkfZveXY/PvtpK1aaU/FW0xt4js2Wxbzzi+M0VtctwZendmKD5hOJVWtqcP76KZTWLYZz1B1wPUGLPnr0KHieR1tbG7RabUhFa7VatLe3g+d5tLa2PlTRLdfqEZExiZabX2NpTJ7EsmOL8MPmC+jeOohDhh+xkE+X2LHLzfiwZC92GfdBm/U89p7dIot55z/ca4Zy6d+wuU4iWaWR2JIYHVpvTuVqvnowtKJVKpXH539MFEVQFAVCCBQKhayiA/kFyxGZwAA0QWQCA0Kmz/tgUS0OnvkUheYUrKxNAU0xEmu48jG2tVfhRn8fKtO3wfT6IVnMOzOd6AZoAjZWBE3R04wAyqTpXCEVvWbNGiiVSpSXl6Onp0dig4OD0Ol04DgOZWVlsoru6enx8HuYog2pGxFJ81iX9jZ+7e+SGAclhBg7EnJ4vG/Y7eG54xUzotM5tP/eCPPZj7AsZpUs5p0f1L9Z4LWeOza8mVKNSJqHIW1TaEWLogiLxYKMjAw0NDRIrK6uDlVVVbBYLJiYmJBVdH19PTIzM2GxWOB2B36meecgDhpHVvQi66kimG07JFZ7bidq8hrxbV4XhoeHPTwv3/oFn+d8h5/X/YFdrx5Azcl3ZTF/+b3n5os7kBtTgiMresE5VXC47H7XQOn1er+/pYaGhsDzPBwOB1iWRWxsLBhm6haZnJzE2NgYRFFEVFQUxsfHkZSUJJ3na1sQBIyOjsLtdkOlUsFut0tsprzf3p1++R7yrXGYGBLARlKIWsSCiaCmctwTYb8tABSgTKQxMSAgfjkHAHDeFTExKEB0ETBKCqqFDLg4Oigbtrkkj5nb3nPBSTB+ww3apUBF8UasTH4NW38r89kltXbt2rD7v+td9JmS+3jp1IJ5ShNYZ0ruQyQCbo1ex+6TmzCkvurzuMfiXUemKRrxyxXzlCawMk3RAAWwKgr8MwxYQvk8jiWE/AUg6tHGCyzvouN07AP7wkVxOtZj7isn7WIJS9N0syAI1Y8qmByFa6mzFXs3ppceGRl5j2GYbyiKGpvvQE+aaBdLIu4suEzuiUX/AG3EJVuesFjhAAAAAElFTkSuQmCC" alt="Travis-CI Build Status" /></a></p>
-<p>Interact with <strong>Google Analytics</strong> using <strong>R</strong></p>
-<p>Classes and methods for interactive use of the Google Analytics core reporting, real-time reporting, multi-channel funnel reporting, metadata, configuration management and Google Tag Manager APIs using R.</p>
+<p>Classes and methods for interactive use of the Google Analytics core reporting, real-time reporting, multi-channel funnel reporting, metadata, configuration management and Google Tag Manager APIs.</p>
 <p>The aim of this package is to support R users in defining reporting queries using natural R expressions instead of being concerned about API technical intricacies like query syntax, character code escaping and API limitations.</p>
 <p>This package provides functions for querying the Google Analytics core reporting, real-time reporting, multi-channel funnel reporting and management APIs, as well as the Google Tag Manager API. Write methods are also provided for the Google Analytics Management and Google Tag Manager APIs so that you can, for example, change tag, property or view settings.</p>
 <div id="updates" class="section level2">