Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change scss import path #2812

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

xiaoyatong
Copy link
Collaborator

@xiaoyatong xiaoyatong commented Dec 2, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能

    • 新增 demoModel 函数,用于生成 React 组件的模板字符串。
    • 改进了 Git 仓库的克隆逻辑,支持根据用户输入重命名目录。
  • 修复

    • 更新了样式表的导入路径,确保在构建过程中正确解析。
  • 文档

    • 移除了未使用的导入,简化了脚本结构。
  • 重构

    • 优化了文件复制和修改的逻辑,增强了条件处理。

Copy link

coderabbitai bot commented Dec 2, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

本次更改涉及多个脚本文件的修改,主要包括删除不再使用的功能、添加新函数以及调整文件导入路径。scripts/build.mjs移除了对appendFile方法的引用,scripts/demo.js引入了一个新的demoModel函数以生成组件模板。其他脚本如clone-jdharmony.jscopy-file.jsreplace-taro-types-alias.js进行了逻辑优化和结构调整。最后,多个组件的样式导入路径从绝对路径更改为相对路径,以确保更好的模块解析。

Changes

文件路径 更改摘要
scripts/build.mjs 移除fs/promises模块中的appendFile方法。
scripts/demo.js 添加demoModel(name)函数以生成React组件模板,并更新导出语句。
scripts/harmony/clone-jdharmony.js 移除未使用的home变量,优化克隆Git仓库的逻辑,支持根据用户输入重命名目录。
scripts/rn/copy-file.js 移除path模块,更新copyFile函数以根据条件修改文件内容,添加特定导入语句。
scripts/taro/replace-taro-types-alias.js 移除replaceAll的注释代码,使用replace进行字符串替换,保留整体结构和错误处理。
scripts/update-v2.js 移除未使用的fs-extra导入,调整createIndexConfig函数的逻辑,删除已注释的条件检查。
src/packages/overlay/demo.taro.tsx 将样式表的导入路径从绝对路径更改为相对路径。
src/packages/skeleton/demo.taro.tsx 将样式表的导入路径从绝对路径更改为相对路径。

Possibly related PRs

Suggested labels

size/XS

Suggested reviewers

  • oasis-cloud

Poem

🐰 在代码的草地上,
兔子欢快地跳跃,
文件路径变更了,
新功能也来到了!
让我们一起庆祝吧,
代码如花绽放,
兔子说:“这真美妙!” 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c6c639d and 5f9bb7e.

📒 Files selected for processing (8)
  • scripts/build.mjs (1 hunks)
  • scripts/demo.js (0 hunks)
  • scripts/harmony/clone-jdharmony.js (0 hunks)
  • scripts/rn/copy-file.js (0 hunks)
  • scripts/taro/replace-taro-types-alias.js (0 hunks)
  • scripts/update-v2.js (0 hunks)
  • src/packages/overlay/demo.taro.tsx (1 hunks)
  • src/packages/skeleton/demo.taro.tsx (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 3.x label Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (c6c639d) to head (5f9bb7e).
Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #2812   +/-   ##
==========================================
  Coverage      83.98%   83.98%           
==========================================
  Files            220      220           
  Lines          17882    17882           
  Branches        2676     2676           
==========================================
  Hits           15019    15019           
  Misses          2858     2858           
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oasis-cloud oasis-cloud merged commit 5c1d072 into jdf2e:feat_v3.x Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants