Merge pull request #2991 from MrWaloo/alpha

Performance increase while importing an equipment without removing existing commands
jeedom · Dec 17, 2024 · 69d3727 · 69d3727
2 parents 94aa378 + b907d62
commit 69d3727
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/core/class/eqLogic.class.php b/core/class/eqLogic.class.php
@@ -1375,18 +1375,18 @@ public function import($_configuration, $_dontRemove = false) {
 		$link_actions = array();
 		$arrayToRemove = [];
 		if (isset($_configuration['commands'])) {
-			foreach (($this->getCmd()) as $eqLogic_cmd) {
-				$exists = 0;
-				foreach ($_configuration['commands'] as $command) {
-					if (isset($command['logicalId']) && $command['logicalId'] == $eqLogic_cmd->getLogicalId()) {
-						$exists++;
+			if (!$_dontRemove) {
+				foreach (($this->getCmd()) as $eqLogic_cmd) {
+					$exists = 0;
+					foreach ($_configuration['commands'] as $command) {
+						if (isset($command['logicalId']) && $command['logicalId'] == $eqLogic_cmd->getLogicalId()) {
+							$exists++;
+						}
+					}
+					if ($exists < 1) {
+						$arrayToRemove[] = $eqLogic_cmd;
 					}
 				}
-				if ($exists < 1) {
-					$arrayToRemove[] = $eqLogic_cmd;
-				}
-			}
-			if (!$_dontRemove) {
 				foreach ($arrayToRemove as $cmdToRemove) {
 					try {
 						$cmdToRemove->remove();