-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): ability to add sounds #489
feat(lib): ability to add sounds #489
Conversation
The audio files from manim-voiceover now get added into the manim-slides configuration. Next step: integrate into Qt and Reveal. Maybe Powerpoint.
Audio is now merged into the slides. All that should be done now is to let Qt, Powerpoint and Reveal take the audio.
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
- Coverage 81.05% 80.14% -0.91%
==========================================
Files 23 23
Lines 1884 1939 +55
==========================================
+ Hits 1527 1554 +27
- Misses 357 385 +28 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
pre-commit.ci informed me that line 51 of manim_slides/convert.py shouldn't have the no-type checker on my computer, but it is required on the workflow.
I added A slight issue I encountered with Update: Only on Python 3.12 Ubuntu is no valid version of Trenton found. The uv |
Hi @PeculiarProgrammer, thank you for your contribution! However, it is unlikely that I will accept such a feature, for two reasons:
Actually, audio is already supported by Your PR is a good solution, but not the ideal one according to me. Regarding the voice-over example, I think it would be great to include such an example in the online documentation, but that still needs ManimCommunity/manim#3763 to be merged (and released) first. What do you think? |
For your information, this is a browser limitation. If an HTML page contains an |
When I was writing this code, I did realize that it was a bit "hacky." Admittedly, adding It would definitely be better to have Out of interest, did you manage to get ManimCommunity/manim#3763 working with just the tests omitted, or have you not yet finished it? |
No I couldn't make it work, for two reasons:
If you have some time, you can try to contribute to my PR directly. I will see how I can give you write accesses. |
You can now add sounds to your presentation!
This PR modifies the code to automatically add the sounds to the slides. This works with either
manim-voiceover
orself.add_sound
.Here are the currently supported presentation mediums:
Fixes Issue
Closes #258
Closes #375
Check List
Check all the applicable boxes:
Note For Reviewers
I modified theBasicExample
scene to usemanim-voiceover
in the example file, but neglected to includemanim-voiceover
as a dependency. I originally had it as an extra, but I'm not sure what you want so I'll leave it not included as a dependency for now. Modifying the example video might also be beneficial along side this change.Edit:
manim-voiceover
is now included as thevoiceover
extra. The example code has been modified to not have a voiceover whenmanim-voiceover
is not installed, and to use either GTTS or OpenAI when it is installed.