Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XMLSerializer #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove XMLSerializer #36

wants to merge 2 commits into from

Conversation

BobDu
Copy link
Member

@BobDu BobDu commented Apr 26, 2024

Ref: #35 (comment)

At the same time, the optional dependency xom has been removed.

Testing done

run mvn clean verify

Signed-off-by: Bob Du <[email protected]>
@basil
Copy link
Member

basil commented Apr 26, 2024

We might be able to do this if there are no transitive usages (--includePluginLibs) and no usages in proprietary CloudBees plugins. See https://www.jenkins.io/doc/developer/plugin-development/usage-in-plugins/.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it explicit that this PR will not be accepted without results of passing usage-in-plugins transitive runs against both open-source Jenkins and CloudBees CI as documented in https://www.jenkins.io/doc/developer/plugin-development/usage-in-plugins/.

@BobDu
Copy link
Member Author

BobDu commented May 8, 2024

pass usage-in-plugins to search api usages in plugin (about cloudbees ci plugin)

in addclass.txt file

net.sf.json.*
net.sf.ezmorph.*

run

mvn clean compile exec:java -Dexec.args="--includeCore -i -p -C addclass.txt --updateCenter https://jenkins-updates.cloudbees.com/update-center/envelope-core-oc/update-center.json?version=2.440.3.8,https://jenkins-updates.cloudbees.com/update-center/envelope-core-mm/update-center.json?version=2.440.3.8"

result has this plugin

alauda-pipeline
BlazeMeterJenkinsPlugin
cloudshell-sandbox
ec2-deployment-dashboard
environment-manager
label-linked-jobs
lotus-connections-plugin
micro-focus-performance-center-integration
requests
scripted-cloud-plugin
sms
test-results-aggregator

But when I read the source code of these plugins, haven't found any actual use of net.sf.json.xml package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants