Merge pull request #78 from jenkinsci/miguel/fix-security-alerts/miss…

…ing-permission-checks Dismiss missing permission check alerts in form validation methods
jenkinsci · Aug 22, 2024 · cc3976a · cc3976a
2 parents 0a44ebd + f8603b8
commit cc3976a
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 0 deletions.
diff --git a/src/main/java/com/codicesoftware/plugins/hudson/PlasticSCM.java b/src/main/java/com/codicesoftware/plugins/hudson/PlasticSCM.java
@@ -680,6 +680,7 @@ public String getDisplayName() {
             return "Plastic SCM";
         }
 
+        @SuppressWarnings("lgtm[jenkins/no-permission-check]")
         @RequirePOST
         public static FormValidation doCheckSelector(@QueryParameter String value) {
             return FormChecker.doCheckSelector(value);
@@ -767,6 +768,7 @@ public String getDirectory() {
         @Extension
         public static class DescriptorImpl extends Descriptor<WorkspaceInfo> {
 
+            @SuppressWarnings("lgtm[jenkins/no-permission-check]")
             @RequirePOST
             public static FormValidation doCheckSelector(@QueryParameter String value) {
                 return FormChecker.doCheckSelector(value);

diff --git a/src/main/java/com/codicesoftware/plugins/hudson/PlasticSCMStep.java b/src/main/java/com/codicesoftware/plugins/hudson/PlasticSCMStep.java
@@ -175,16 +175,19 @@ public String getDisplayName() {
             return "Plastic SCM";
         }
 
+        @SuppressWarnings("lgtm[jenkins/no-permission-check]")
         @RequirePOST
         public FormValidation doCheckBranch(@QueryParameter String value) {
             return FormChecker.doCheckBranch(value);
         }
 
+        @SuppressWarnings("lgtm[jenkins/no-permission-check]")
         @RequirePOST
         public FormValidation doCheckRepository(@QueryParameter String value) {
             return FormChecker.doCheckRepository(value);
         }
 
+        @SuppressWarnings("lgtm[jenkins/no-permission-check]")
         @RequirePOST
         public FormValidation doCheckServer(@QueryParameter String value) {
             return FormChecker.doCheckServer(value);

diff --git a/src/main/java/com/codicesoftware/plugins/jenkins/mergebot/MergebotScm.java b/src/main/java/com/codicesoftware/plugins/jenkins/mergebot/MergebotScm.java
@@ -222,6 +222,7 @@ public ListBoxModel doFillCredentialsIdItems(@AncestorInPath Item item, @QueryPa
             return FormFiller.doFillCredentialsIdItems(item, credentialsId);
         }
 
+        @SuppressWarnings("lgtm[jenkins/no-permission-check]")
         @RequirePOST
         public static FormValidation doCheckSpeckAttributeName(@QueryParameter String value) {
             return Util.fixEmpty(value) == null

diff --git a/src/main/java/com/codicesoftware/plugins/jenkins/mergebot/MergebotScmStep.java b/src/main/java/com/codicesoftware/plugins/jenkins/mergebot/MergebotScmStep.java
@@ -93,6 +93,7 @@ public static String getDefaultSpecAttributeName() {
             return MergebotScm.UPDATE_TO_SPEC_PARAMETER_NAME;
         }
 
+        @SuppressWarnings("lgtm[jenkins/no-permission-check]")
         @RequirePOST
         public static FormValidation doCheckSpecAttributeName(@QueryParameter String value) {
             return Util.fixEmpty(value) == null

diff --git a/src/main/java/com/codicesoftware/plugins/jenkins/tools/CmTool.java b/src/main/java/com/codicesoftware/plugins/jenkins/tools/CmTool.java
@@ -166,6 +166,7 @@ public String getId() {
             return "plasticscm-cli";
         }
 
+        @SuppressWarnings("lgtm[jenkins/no-permission-check]")
         @RequirePOST
         @Override
         public FormValidation doCheckHome(@QueryParameter File value) {