Code cleanup after upgrade #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://www.jenkins.io/doc/developer/security/form-validation/#protecting-from-csrf, the @RequirePOST is an older annotation for preventing CSRF which presents a form for the user to resubmit the request using POST. However, in this case we can safely use the newer @post annotation, which limits processing to the POST verb. Other verbs will return a 404 response. It's the recommended action for validation methods. Signed-off-by: Miguel González <[email protected]>
Signed-off-by: Miguel González <[email protected]>
Signed-off-by: Miguel González <[email protected]>
Signed-off-by: Miguel González <[email protected]>
Signed-off-by: Miguel González <[email protected]>
Signed-off-by: Miguel González <[email protected]>
Signed-off-by: Miguel González <[email protected]>
Signed-off-by: Miguel González <[email protected]>
Signed-off-by: Miguel González <[email protected]>
Signed-off-by: Miguel González <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading the minimum Jenkins version to
2.440.3and the Java version to 17, there are a few warnings popping up. We're also using deprecated code and outdated java statements that would benefit from an upgrade.There are also four security alerts fixed in this PR:
Testing done
I tested the plugin manually in the official docker container. The
CmTool, its custom installer and the two VCS implementations (mergebot and regular) worked as expected, for pipelines and freestyle projects.Submitter checklist