[JENKINS-74081] Migrate legacy checkUrl in /ValidatingStringParameterDefinition/index.jelly
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terDefinition/index.jelly`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public FormValidation doValidate(@QueryParameter("regex") String regex, | ||
| @QueryParameter("failedValidationMessage") final String failedValidationMessage, | ||
| @QueryParameter("value") final String value) { | ||
| public FormValidation doValidate(@QueryParameter String regex, @QueryParameter final String failedValidationMessage, |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
res0nance
approved these changes
Nov 16, 2024
|
JENKINS-74871 reports that the most recent release of the plugin no longer shows the provided value as a parameter of the build. |
yaroslavafenkin
commented
Nov 17, 2024
|
|
||
| <f:entry title="${h.xmlEscape(it.name)}" description="${it.formattedDescription}"> | ||
| <div name="parameter" description="${it.formattedDescription}"> | ||
| <input type="hidden" name="name" value="${it.name}" /> |
There was a problem hiding this comment.
Whoops, I guess this line had to stay. I'll fix this tomorrow morning CET.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-74081
Testing done
Before the change
After the change
Submitter checklist