Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added :titleize filter #28

Merged
merged 1 commit into from
Jul 10, 2012
Merged

Added :titleize filter #28

merged 1 commit into from
Jul 10, 2012

Conversation

kagd
Copy link
Contributor

@kagd kagd commented Jul 10, 2012

Used active support as a reference for this implementation.

All the string tests pass.

Also, my date tests were failing because there was no file for 0600. I added the file, although, it was never passing the tests for me. Might have been something that I was missing.

@kagd
Copy link
Contributor Author

kagd commented Jul 10, 2012

I should note that I did not generate a new readme with the :titleize documentation since it appears that it is generated by some system, and I am not sure which.

@kagd
Copy link
Contributor Author

kagd commented Jul 10, 2012

OSX 10.7.4 and jison = 0.3.2

@kagd
Copy link
Contributor Author

kagd commented Jul 10, 2012

Yes, all the specs passed except for the date 0600 one.

@kagd
Copy link
Contributor Author

kagd commented Jul 10, 2012

I will have to think about the date test a bit. I'm sure that there has to be a way to test it without having to worry about timezones.

@jeremyruppel jeremyruppel merged commit 2910607 into jeremyruppel:master Jul 10, 2012
@jeremyruppel
Copy link
Owner

This looks great though, man. Merged and published. Thanks for the help!

I know there are several Date-mocking packages out there, so I'm wondering if one of those might be useful in avoiding the travis-time-zone debacle. Anyhow, I've filed #29 for that. Thanks!

@kagd
Copy link
Contributor Author

kagd commented Jul 10, 2012

No problem. This is a great renderer and I am glad to give back. I will look around for some options to deal with the date testing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants