Rework own property enumeration #4773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
property_list
branch
5 times, most recently
from
fbb8496 to
4168de3
Compare
zherczeg
force-pushed
the
property_list
branch
from
4168de3 to
7088062
Compare
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
property_list
branch
from
7088062 to
aca6939
Compare
Properry name filtering is done during the enumeration. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
property_list
branch
from
aca6939 to
14599ed
Compare
|
Please rebase. |
|
@zherczeg, please rebase if still needed or close if it is not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properry name filtering is done during the enumeration.
Should use less memory, since no "sorting" phase, and should be much faster in some corner cases, e.g. when the indexed properties are not needed for a large typed array / large strings.