WIP: Complete the Docker compose testing setup #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
commented
Dec 10, 2024
|
|
||
| gemspec | ||
| eval_gemfile "#{__dir__}/Gemfile.base" |
There was a problem hiding this comment.
This change seems solid: In Docker context, test the latest release.
| COPY Gemfile* *.gemspec /app/ | ||
| RUN mkdir -p /app/lib/active_record_upsert | ||
| COPY lib/active_record_upsert/version.rb /app/lib/active_record_upsert/ | ||
| WORKDIR /app | ||
| RUN bundle install | ||
| COPY . /app | ||
| CMD bin/run_docker_test.sh | ||
| CMD [ "bin/run_docker_test.sh" ] |
There was a problem hiding this comment.
This is the "JSON args". https://docs.docker.com/reference/build-checks/json-args-recommended/
| @@ -0,0 +1,13 @@ | |||
| COMMAND ?= `grep 'web' Procfile | cut -d ':' -f2` | |||
There was a problem hiding this comment.
Suggested change
| COMMAND ?= `grep 'web' Procfile | cut -d ':' -f2` |
| @@ -0,0 +1 @@ | |||
| b8c94d1feb3f0a66ec0bd2a83f9c1c8f0b5e112f81f6c270a03f8a45a5158ba999121e4eee44b136de6655c1a37ecfa80b63fc35f37d80784cf36a02cc123cf6 | |||
There was a problem hiding this comment.
This could go in the .gitignore I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is about the docker-compose.yml and Dockerfile and also the bin/run_docker_test.sh - they simply aren't there, yet.
I wanted to run the tests locally – seeing them run, and I ran into a setup problem, listed in #146
I made a tiny change in this commit, to address that, but I have not yet seen it run, since the setup isn't complete yet.
So, a slow draft PR process. Anyone can help this!