Skip to content
This repository has been archived by the owner on Nov 20, 2020. It is now read-only.

LZ4 compression support #219

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

LZ4 compression support #219

wants to merge 5 commits into from

Conversation

vchekan
Copy link

@vchekan vchekan commented Apr 12, 2018

Implements #129

eulerfx
eulerfx reviewed Apr 18, 2018
View reviewed changes
src/kafunk/Native/lz4.fs Outdated
@@ -0,0 +1,176 @@
namespace Kafunk.Native
#nowarn "9"
module Lz4Framing =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be internal?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

eulerfx
eulerfx reviewed Apr 18, 2018
View reviewed changes
src/kafunk/Native/Loader.fs Outdated
namespace Kafunk.Native

/// Windlows pre-load dll from x86/x64 folder depending on Environment.Is64BitProcess
module Loader =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also make internal, rather than namespace do module internal Kafunk.NativelLoader

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

eulerfx
eulerfx reviewed Apr 18, 2018
View reviewed changes
RELEASE_NOTES.md Outdated
@@ -1,3 +1,6 @@
### 0.1.17 - 12.4.2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do an alpha first 0.1.17-alpha1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eulerfx eulerfx eulerfx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchekan @eulerfx